View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007646 | GNUnet | hello library | public | 2023-01-29 23:39 | 2024-02-29 22:46 |
| Reporter | ulfvonbelow | Assigned To | schanzen | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.19.4 | Fixed in Version | 0.19.4 | ||
| Summary | 0007646: Memory leak in GNUNET_HELLO_extract_address | ||||
| Description | 'data' isn't freed. | ||||
| Steps To Reproduce | ./configure --enable-sanitizer make make install make check | ||||
| Additional Information | Patch attached. | ||||
| Tags | memory-leak, patch | ||||
| Attached Files | 0001-HELLO-fix-memory-leak-in-GNUNET_HELLO_extract_addres.patch (788 bytes)
From 018a798a91c469c581517d727544ca03a33016a1 Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sun, 29 Jan 2023 07:01:27 -0600
Subject: [PATCH] HELLO: fix memory leak in GNUNET_HELLO_extract_address.
---
src/hello/hello-ng.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/hello/hello-ng.c b/src/hello/hello-ng.c
index da3a069e0..9d77e4f80 100644
--- a/src/hello/hello-ng.c
+++ b/src/hello/hello-ng.c
@@ -169,9 +169,11 @@ GNUNET_HELLO_extract_address (const void *raw,
sig,
public_key))
{
+ GNUNET_free (data);
GNUNET_break_op (0);
return NULL;
}
+ GNUNET_free (data);
*mono_time = raw_mono_time;
*nt = raw_nt;
return GNUNET_strdup (raw_addr);
--
2.38.1
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-29 23:39 | ulfvonbelow | New Issue | |
| 2023-01-29 23:39 | ulfvonbelow | Tag Attached: bug | |
| 2023-01-29 23:39 | ulfvonbelow | Tag Attached: memory-leak | |
| 2023-01-29 23:39 | ulfvonbelow | Tag Attached: patch | |
| 2023-01-29 23:39 | ulfvonbelow | File Added: 0001-HELLO-fix-memory-leak-in-GNUNET_HELLO_extract_addres.patch | |
| 2023-02-06 05:56 | schanzen | Assigned To | => schanzen |
| 2023-02-06 05:56 | schanzen | Status | new => resolved |
| 2023-02-06 05:56 | schanzen | Resolution | open => fixed |
| 2023-02-06 05:56 | schanzen | Fixed in Version | => 0.19.4 |
| 2023-02-06 06:19 | schanzen | Target Version | => 0.19.4 |
| 2023-06-01 20:26 | schanzen | Note Added: 0020223 | |
| 2023-06-01 20:26 | schanzen | Status | resolved => closed |
| 2024-02-29 22:46 | Christian Grothoff | Tag Detached: bug |