View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007635 | GNUnet | reclaim | public | 2023-01-29 22:34 | 2023-06-01 20:26 |
| Reporter | ulfvonbelow | Assigned To | schanzen | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.19.4 | Fixed in Version | 0.19.4 | ||
| Summary | 0007635: Memory leak in gnunet-reclaim | ||||
| Description | attr_list is freed, but its elements are not. | ||||
| Steps To Reproduce | ./configure --enable-sanitizer make make install make check | ||||
| Additional Information | Patch attached. | ||||
| Tags | memory-leak, patch | ||||
| Attached Files | 0001-RECLAIM-don-t-leak-the-elements-of-attr_list.patch (865 bytes)
From e8ebd39138a7ceadde70189800ff6679e166ac13 Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sun, 29 Jan 2023 06:15:16 -0600
Subject: [PATCH] RECLAIM: don't leak the elements of attr_list.
---
src/reclaim/gnunet-reclaim.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/reclaim/gnunet-reclaim.c b/src/reclaim/gnunet-reclaim.c
index da5f90409..cb8703495 100644
--- a/src/reclaim/gnunet-reclaim.c
+++ b/src/reclaim/gnunet-reclaim.c
@@ -218,7 +218,10 @@ do_cleanup (void *cls)
if (NULL != identity_handle)
GNUNET_IDENTITY_disconnect (identity_handle);
if (NULL != attr_list)
- GNUNET_free (attr_list);
+ {
+ GNUNET_RECLAIM_attribute_list_destroy (attr_list);
+ attr_list = NULL;
+ }
if (NULL != attr_to_delete)
GNUNET_free (attr_to_delete);
if (NULL == credential_type)
--
2.38.1
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-29 22:34 | ulfvonbelow | New Issue | |
| 2023-01-29 22:34 | ulfvonbelow | Tag Attached: memory-leak | |
| 2023-01-29 22:34 | ulfvonbelow | Tag Attached: patch | |
| 2023-01-29 22:34 | ulfvonbelow | File Added: 0001-RECLAIM-don-t-leak-the-elements-of-attr_list.patch | |
| 2023-02-06 06:10 | schanzen | Assigned To | => schanzen |
| 2023-02-06 06:10 | schanzen | Status | new => resolved |
| 2023-02-06 06:10 | schanzen | Resolution | open => fixed |
| 2023-02-06 06:10 | schanzen | Fixed in Version | => 0.19.4 |
| 2023-02-06 06:19 | schanzen | Target Version | => 0.19.4 |
| 2023-06-01 20:26 | schanzen | Note Added: 0020232 | |
| 2023-06-01 20:26 | schanzen | Status | resolved => closed |