View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007633 | GNUnet | reclaim | public | 2023-01-29 22:34 | 2023-06-01 20:26 |
| Reporter | ulfvonbelow | Assigned To | schanzen | ||
| Priority | normal | Severity | trivial | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.19.4 | Fixed in Version | 0.19.4 | ||
| Summary | 0007633: DID_key_covert_gnunet_to_multibase_base64 seems to be missing an 'n' | ||||
| Description | s/covert/convert/g It's a bit distracting and confusing to read. | ||||
| Additional Information | Attached patch renames it and updates its callers. | ||||
| Tags | patch | ||||
| Attached Files | 0001-RECLAIM-rename-G_D_key_covert_.-to-G_D_key_convert_.patch (3,600 bytes)
From 7001b82228492d710da275bf4e6056a547b56f9a Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sun, 29 Jan 2023 06:06:47 -0600
Subject: [PATCH] RECLAIM: rename G_D_key_covert_... to G_D_key_convert_...
I think this misspelling would tend to distract the reader.
---
src/reclaim/did_helper.c | 6 +++---
src/reclaim/did_helper.h | 4 ++--
src/reclaim/test_did_helper.c | 8 ++++----
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/reclaim/did_helper.c b/src/reclaim/did_helper.c
index 1c04ede33..5600b7440 100644
--- a/src/reclaim/did_helper.c
+++ b/src/reclaim/did_helper.c
@@ -98,7 +98,7 @@ DID_did_to_pkey (const char *did, struct GNUNET_IDENTITY_PublicKey *pkey)
* @brief Convert a base 64 encoded public key to a GNUNET key
*/
struct GNUNET_IDENTITY_PublicKey *
-GNUNET_DID_key_covert_multibase_base64_to_gnunet (char *pkey_str)
+GNUNET_DID_key_convert_multibase_base64_to_gnunet (char *pkey_str)
{
return NULL;
}
@@ -107,7 +107,7 @@ GNUNET_DID_key_covert_multibase_base64_to_gnunet (char *pkey_str)
* @brief Convert GNUNET key to a base 64 encoded public key
*/
char *
-DID_key_covert_gnunet_to_multibase_base64 (struct
+DID_key_convert_gnunet_to_multibase_base64 (struct
GNUNET_IDENTITY_PublicKey *
pkey)
{
@@ -154,7 +154,7 @@ DID_pkey_to_did_document (struct GNUNET_IDENTITY_PublicKey *pkey)
did_str = DID_pkey_to_did (pkey);
GNUNET_asprintf (&verify_id_str, "%s#key-1", did_str);
- pkey_multibase_str = DID_key_covert_gnunet_to_multibase_base64 (pkey);
+ pkey_multibase_str = DID_key_convert_gnunet_to_multibase_base64 (pkey);
didd_json = json_pack (
"{s:[ss], s:s, s:[{s:s, s:s, s:s, s:s}], s:[s], s:[s]}",
diff --git a/src/reclaim/did_helper.h b/src/reclaim/did_helper.h
index 5cad48ca8..fea86af5e 100644
--- a/src/reclaim/did_helper.h
+++ b/src/reclaim/did_helper.h
@@ -52,13 +52,13 @@ DID_did_to_pkey (const char *did, struct GNUNET_IDENTITY_PublicKey *pkey);
// * @brief Convert a base 64 encoded public key to a GNUNET key
// */
// struct GNUNET_IDENTITY_PublicKey *
-// GNUNET_DID_key_covert_multibase_base64_to_gnunet(char *);
+// GNUNET_DID_key_convert_multibase_base64_to_gnunet(char *);
/**
* @brief Convert GNUNET key to a base 64 encoded public key
*/
char *
-DID_key_covert_gnunet_to_multibase_base64 (struct
+DID_key_convert_gnunet_to_multibase_base64 (struct
GNUNET_IDENTITY_PublicKey *);
/**
diff --git a/src/reclaim/test_did_helper.c b/src/reclaim/test_did_helper.c
index 446c199fc..c7c6f3110 100644
--- a/src/reclaim/test_did_helper.c
+++ b/src/reclaim/test_did_helper.c
@@ -84,13 +84,13 @@ test_GNUNET_DID_did_to_pkey ()
}
// void
-// test_GNUNET_DID_key_covert_multibase_base64_to_gnunet ();
+// test_GNUNET_DID_key_convert_multibase_base64_to_gnunet ();
void
-test_GNUNET_DID_key_covert_gnunet_to_multibase_base64 ()
+test_GNUNET_DID_key_convert_gnunet_to_multibase_base64 ()
{
char *multibase_key;
- multibase_key = DID_key_covert_gnunet_to_multibase_base64 (&test_pkey);
+ multibase_key = DID_key_convert_gnunet_to_multibase_base64 (&test_pkey);
GNUNET_assert (strcmp (test_multibase_key, multibase_key) == 0);
}
@@ -127,6 +127,6 @@ main ()
test_GNUNET_DID_pkey_to_did ();
test_GNUNET_DID_did_to_pkey ();
test_GNUNET_DID_pkey_to_did_document ();
- test_GNUNET_DID_key_covert_gnunet_to_multibase_base64 ();
+ test_GNUNET_DID_key_convert_gnunet_to_multibase_base64 ();
return 0;
}
--
2.38.1
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-29 22:34 | ulfvonbelow | New Issue | |
| 2023-01-29 22:34 | ulfvonbelow | Tag Attached: patch | |
| 2023-01-29 22:34 | ulfvonbelow | File Added: 0001-RECLAIM-rename-G_D_key_covert_.-to-G_D_key_convert_.patch | |
| 2023-02-06 06:08 | schanzen | Assigned To | => schanzen |
| 2023-02-06 06:08 | schanzen | Status | new => resolved |
| 2023-02-06 06:08 | schanzen | Resolution | open => fixed |
| 2023-02-06 06:08 | schanzen | Fixed in Version | => 0.19.4 |
| 2023-02-06 06:19 | schanzen | Target Version | => 0.19.4 |
| 2023-06-01 20:26 | schanzen | Note Added: 0020234 | |
| 2023-06-01 20:26 | schanzen | Status | resolved => closed |