View Issue Details

IDProjectCategoryView StatusLast Update
0007578Talerwallet (TS core)public2023-03-05 02:33
ReporterFlorian Dold Assigned Toavalos  
PrioritylowSeveritytweakReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version0.9.3 
Summary0007578: rename wallet-core p2p payments requests
DescriptionThe current API has some weird asymmetries and is rather confusing.

In particular, the preparePeer* requests don't prepare anything!

It's not even clear what preparePeerPullPayment is supposed to do. Is it about an initiation? An incoming payment? Why is there an effective and raw amount returned? Very confusing ...

We need to properly document all those calls and make sure they have clearer names.
TagsNo tags attached.


has duplicate 0007565 closedFlorian Dold improve consistency of the wallet's peer payments API 


Florian Dold

2023-02-17 02:27

manager   ~0019857

The FIXME comments in the wallet API types file suggest new, better names:

Alternatively, since the wallet API is now growing larger and larger, we could also move to namespaced names (but using the same basic terminology).

Florian Dold

2023-02-20 01:46

manager   ~0019884

The operations now have new names in wallet-core.

The old names are still supported, see translateLegacyOperationNames (

The Android wallet should switch to the new names, then we can remove the mapping.


2023-02-28 17:10

developer   ~0019909

Apparently, Torsten already took care of this. Could you please confirm?

Florian Dold

2023-03-05 02:33

manager   ~0019920

Yes, this is resolved.

Issue History

Date Modified Username Field Change
2023-01-13 01:45 Florian Dold New Issue
2023-01-13 01:45 Florian Dold Status new => assigned
2023-01-13 01:45 Florian Dold Assigned To => Florian Dold
2023-01-13 02:30 Florian Dold Relationship added has duplicate 0007565
2023-01-13 17:02 Christian Grothoff Severity minor => tweak
2023-02-17 02:27 Florian Dold Status assigned => feedback
2023-02-17 02:27 Florian Dold Note Added: 0019857
2023-02-17 02:55 Florian Dold Priority normal => low
2023-02-17 02:55 Florian Dold Summary clarify / restructure wallet-core p2p payments API => rename wallet-core p2p payments requests
2023-02-17 15:06 Florian Dold Target Version 0.9.2 => 0.9.4
2023-02-20 01:45 Florian Dold Assigned To Florian Dold => avalos
2023-02-20 01:46 Florian Dold Note Added: 0019884
2023-02-20 01:46 Florian Dold Status feedback => assigned
2023-02-20 01:47 Florian Dold Description Updated
2023-02-20 01:47 Florian Dold Target Version 0.9.4 => 0.9.3
2023-02-28 17:10 avalos Note Added: 0019909
2023-03-05 02:33 Florian Dold Status assigned => resolved
2023-03-05 02:33 Florian Dold Resolution open => fixed
2023-03-05 02:33 Florian Dold Note Added: 0019920