View Issue Details

IDProjectCategoryView StatusLast Update
0007529Talerwallet (Android App)public2023-09-23 15:09
ReporterWindfisch Assigned Togrote  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionunable to reproduce 
Product Version0.9 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007529: Withdrawing 13.37 or 133.7 results in rounding errors.
DescriptionThe android wallet displays fees and amounts wrong. 133.7 KUDOS become 133.699999999.
Steps To Reproduce1. Use the android wallet
2. Withdraw 13.37 coins from an exchange with (0.01, 0.10, 1.00, 10.00, 100.00, 1000.00) as denominations, or withdraw 133.7 coins from taler demo exchange.
3. In the confirmation screen for the demo wallet, I get:
  - "Withdraw: 133.4 KUDOS" (wrong, afaik it should be 133.5 due to the 0.2 fees)
  - "Selected amount: 133.69999999 KUDOS" (wrong!)
  - "Fees: 0.29999999 KUDOS" (wrong)

Additional InformationSounds like a floating point issue to me.
TagsNo tags attached.

Activities

Florian Dold

2023-02-06 13:39

manager   ~0019767

I've just re-confirmed that this is not a wallet-core issue (by doing the demo withdrawal with the CLI). The wallet internally also doesn't ever use floating point numbers for amounts. So this is a UI issue.

grote

2023-02-21 14:02

developer   ~0019896

When withdrawing 137.7 KUDOS from exchange.demo.taler.net, the Withdraw UI shows me

Withdraw 137.2 KUDOS
Chosen Amount: 137.37 KUDOS
Fee: -0.17 KUDOS

which looks ok. Any other way to reproduce this?

Florian Dold

2023-04-04 18:08

manager   ~0020014

We can't reproduce this in the Android UI (anymore?), and we don't use any floating point computation in wallet-core. So this should be fixed (and I'm not sure where it occurred in the first place).

Issue History

Date Modified Username Field Change
2022-12-22 16:53 Windfisch New Issue
2022-12-22 16:53 Windfisch Status new => assigned
2022-12-22 16:53 Windfisch Assigned To => Florian Dold
2023-01-08 10:20 Christian Grothoff Product Version => 0.9
2023-01-08 10:20 Christian Grothoff Target Version => 0.9.2
2023-02-06 13:39 Florian Dold Assigned To Florian Dold =>
2023-02-06 13:39 Florian Dold Assigned To => grote
2023-02-06 13:39 Florian Dold Note Added: 0019767
2023-02-21 14:02 grote Note Added: 0019896
2023-02-24 14:58 Florian Dold Target Version 0.9.2 => 0.9.3
2023-02-24 14:58 Florian Dold Status assigned => feedback
2023-04-04 18:08 Florian Dold Status feedback => resolved
2023-04-04 18:08 Florian Dold Resolution open => unable to reproduce
2023-04-04 18:08 Florian Dold Note Added: 0020014
2023-09-23 15:07 Christian Grothoff Fixed in Version => 0.9.3
2023-09-23 15:09 Christian Grothoff Status resolved => closed