View Issue Details

IDProjectCategoryView StatusLast Update
0007526Talerlibeufin-bank-ui (SPA)public2023-01-26 22:53
ReporterWindfisch Assigned Tosebasjm  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Target Version0.9.1Fixed in Version0.9.1 
Summary0007526: Demobank webui does not enable wire transfer "Send" button
DescriptionThe following patch resolves the issue:

https://github.com/Windfisch/taler-wallet-core/compare/master...wire_transfer_button_always_disabled

Patch is attached
TagsNo tags attached.
Attached Files
0001-Fix-enable-wire-transfer-send-button.patch (1,109 bytes)   
From ecb6bf7d7ec1001058d9f4303bdf6ccdcbd3cdb8 Mon Sep 17 00:00:00 2001
From: Florian Jung <flo@windfis.ch>
Date: Mon, 19 Dec 2022 16:34:02 +0100
Subject: [PATCH] Fix: enable wire transfer "send" button

---
 packages/demobank-ui/src/pages/PaytoWireTransferForm.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/demobank-ui/src/pages/PaytoWireTransferForm.tsx b/packages/demobank-ui/src/pages/PaytoWireTransferForm.tsx
index 1237f5eb..aa76f61e 100644
--- a/packages/demobank-ui/src/pages/PaytoWireTransferForm.tsx
+++ b/packages/demobank-ui/src/pages/PaytoWireTransferForm.tsx
@@ -55,7 +55,7 @@ export function PaytoWireTransferForm({
 
   let parsedAmount = undefined;
 
-  const errorsWire = {
+  const errorsWire = undefinedIfEmpty({
     iban: !submitData?.iban
       ? i18n.str`Missing IBAN`
       : !/^[A-Z0-9]*$/.test(submitData.iban)
@@ -69,7 +69,7 @@ export function PaytoWireTransferForm({
       : Amounts.isZero(parsedAmount)
       ? i18n.str`Should be greater than 0`
       : undefined,
-  };
+  });
 
   if (!pageState.isRawPayto)
     return (
-- 
2.37.0

Activities

sebasjm

2022-12-19 18:53

developer   ~0019519

nice catch, thanks!

commit 45691dc991945d8c0a3d4bc95078bd1af5932927

Issue History

Date Modified Username Field Change
2022-12-19 16:38 Windfisch New Issue
2022-12-19 16:38 Windfisch Status new => assigned
2022-12-19 16:38 Windfisch Assigned To => sebasjm
2022-12-19 16:38 Windfisch File Added: 0001-Fix-enable-wire-transfer-send-button.patch
2022-12-19 18:53 sebasjm Status assigned => resolved
2022-12-19 18:53 sebasjm Resolution open => fixed
2022-12-19 18:53 sebasjm Note Added: 0019519
2023-01-23 22:25 Christian Grothoff Target Version => 0.9.1
2023-01-23 22:25 Christian Grothoff Fixed in Version => 0.9.1
2023-01-26 22:53 Christian Grothoff Status resolved => closed
2023-12-03 01:21 Christian Grothoff Category demobank-ui => libeufin-bank-ui
2024-01-12 14:10 Christian Grothoff Category libeufin-bank-ui => libeufin-bank-ui (SPA)