View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007524 | Taler | demobank-ui | public | 2022-12-19 03:16 | 2023-01-26 22:53 |
| Reporter | Windfisch | Assigned To | sebasjm | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.9 | ||||
| Target Version | 0.9.1 | Fixed in Version | 0.9.1 | ||
| Summary | 0007524: demobank webui cannot handle insanely high amounts of money | ||||
| Description | When showing the profile page with the balance, the webui fails to render my 10^376 KUDOS. Instead, it displays "Retrieving the profile page..." forever and logs an error in the browser's debug window (see below). | ||||
| Steps To Reproduce | Execute something similar to the following (e.g. by making a smaller transaction, snooping on the request in the browser debug tools, "copy as CURL" and then alter the payload to contain a little more money) Then refresh either account's balance pages. curl 'https://bank.demo.taler.net/demobanks/default/access-api/accounts/windfisch/transactions' \ -H 'Accept: */*' \ -H 'Accept-Language: en-US,en;q=0.9,de;q=0.8' \ -H 'Cache-Control: no-cache' \ -H 'Connection: keep-alive' \ -H 'Origin: https://bank.demo.taler.net' \ -H 'Pragma: no-cache' \ -H 'Referer: https://bank.demo.taler.net/webui/' \ -H 'Sec-Fetch-Dest: empty' \ -H 'Sec-Fetch-Mode: cors' \ -H 'Sec-Fetch-Site: same-origin' \ -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.53 Safari/537.36' \ -H 'authorization: Basic d2luZGZpc2NoOmZpY2tlbjIz' \ -H 'content-type: application/json' \ -H 'sec-ch-ua: "Chromium";v="103", ".Not/A)Brand";v="99"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "Linux"' \ --data-raw '{"paytoUri":"payto://iban/DE394602?message=lol","amount":"KUDOS:9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999"}' \ --compressed | ||||
| Additional Information | Stack trace in the browser: Uncaught (in promise) Error: Can't parse amount: "KUDOS:10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000098" at Amounts.parseOrThrow (amounts.ts:357:15) at _.Account [as constructor] (index.tsx:2223:27) at _.O [as render] (index.js:515:14) at j (index.js:181:12) at component.js:130:3 at Array.some (<anonymous>) at g (component.js:220:9) | ||||
| Tags | No tags attached. | ||||
|
|
I like your style. commit 8c8aad4c21fde2cd37e25ccd4c723a308b79439b make the SPA not to break if the account is in an invalid state. But 1.- this may be solved in the sandbox server so the account should not go into an invalid state. 2.- If for any reason the account goes to an invalid state, it will be nice to have a endpoint to reset the account state to the initial one since this is a testing environment. Could you please open bugs for 1 and 2 in libeufin sandbox if you agree? we should check if @MS agrees. |
|
|
As of point 1: we should define what a 'invalid' state may mean, first. In this this particular case, setting limits on the amounts being transferred seems beneficial. For example, if an amount is above X, then the transfer gets staged and needs to be approved. As of 2: the Sandbox is now being used for setups that are not very much of a testing environment anymore. So resetting an account's state might be problematic in this regard. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-12-19 03:16 | Windfisch | New Issue | |
| 2022-12-19 03:16 | Windfisch | Status | new => assigned |
| 2022-12-19 03:16 | Windfisch | Assigned To | => sebasjm |
| 2022-12-20 14:22 | sebasjm | Status | assigned => resolved |
| 2022-12-20 14:22 | sebasjm | Resolution | open => fixed |
| 2022-12-20 14:22 | sebasjm | Note Added: 0019522 | |
| 2022-12-20 14:32 | MS | Note Added: 0019523 | |
| 2023-01-23 22:25 | Christian Grothoff | Target Version | => 0.9.1 |
| 2023-01-23 22:25 | Christian Grothoff | Fixed in Version | => 0.9.1 |
| 2023-01-26 22:53 | Christian Grothoff | Status | resolved => closed |
