View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007503 | Taler | wallet-core | public | 2022-11-30 15:04 | 2023-02-21 16:39 |
Reporter | sebasjm | Assigned To | Florian Dold | ||
Priority | low | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | no change required | ||
Target Version | 0.9.2 | Fixed in Version | 0.9.2 | ||
Summary | 0007503: remove NotificationType.WaitingForRetry notification | ||||
Description | The notification just let the client now that a interaction has occurred wich is not meaningful. I think NotificationType.PendingOperationProcessed should be enough if what we want is to show progress | ||||
Tags | No tags attached. | ||||
|
I don't think we should remove it. It doesn't let the client know that some interaction has occurred, it lets the client know that (1) the wallet's retry loop is still active and (2) how much work the wallet still has to do in general. It's also important in tests. The new variant of integration tests relies purely on notifications, and the WaitingForRetry notification lets us know whether the wallet is "done" and we can inspect the state to see if the tests succeeded. |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-11-30 15:04 | sebasjm | New Issue | |
2022-11-30 15:04 | sebasjm | Status | new => assigned |
2022-11-30 15:04 | sebasjm | Assigned To | => Florian Dold |
2023-02-17 02:53 | Florian Dold | Priority | normal => low |
2023-02-17 12:42 | Florian Dold | Status | assigned => resolved |
2023-02-17 12:42 | Florian Dold | Resolution | open => no change required |
2023-02-17 12:42 | Florian Dold | Note Added: 0019862 | |
2023-02-21 16:39 | Christian Grothoff | Fixed in Version | => 0.9.2 |
2023-02-21 16:39 | Christian Grothoff | Target Version | => 0.9.2 |
2023-02-21 16:39 | Christian Grothoff | Status | resolved => closed |
2023-04-13 20:36 | Florian Dold | Category | wallet (TS core) => wallet-core |