View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007321 | Taler | wallet-core | public | 2022-09-05 15:47 | 2023-09-23 15:58 |
| Reporter | Florian Dold | Assigned To | sebasjm | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | assigned | Resolution | open | ||
| Target Version | post-1.0 | ||||
| Summary | 0007321: "pnpm install" complains about unmet peer dependencies | ||||
| Description | I've temporarily made peer dependency errors non-strict via .npmrc. However, we should still sort out these peer dependency issues: Here's the log: ERR_PNPM_PEER_DEP_ISSUES Unmet peer dependencies packages/anastasis-webui └─┬ eslint-plugin-header 3.1.1 └── ✕ missing peer eslint@>=7.7.0 Peer dependencies that should be installed: eslint@>=7.7.0 packages/taler-wallet-webextension ├─┬ @linaria/react 3.0.0-beta.4 │ └── ✕ missing peer react@>=16 ├─┬ @linaria/webpack-loader 3.0.0-beta.4 │ └─┬ @linaria/webpack5-loader 3.0.0-beta.7 │ └── ✕ missing peer webpack@>=5 └─┬ babel-loader 8.2.3 └── ✕ missing peer webpack@>=2 Peer dependencies that should be installed: react@>=16 webpack@>=5.0.0 | ||||
| Tags | No tags attached. | ||||
|
|
I was not able to reproduce the issue with $ pnpm --version 7.13.3 and $ pnpm --version 6.32.24 I have removed the .npmrc file, could you please tell me how to reproduce this? Maybe a special pnpm version? I think the solution may be adding this to the package.json { ... "pnpm": { "peerDependencyRules": { "ignoreMissing": ["react","webpack"] } } } |
|
|
@sebastian: You need to start with an empty repo for this. Please add the "ignoreMissing" settings where appropriate. I think it's an okay fix. |
|
|
After cloning a new repo and building from scratch, still can't reproduce Full output $ pnpm --version 7.14.2 $ rm -rf wal2/ ; git clone wallet-core/ wal2; cd wal2; pnpm install Cloning into 'wal2'... done. Scope: all 13 workspace projects Lockfile is up to date, resolution step is skipped Packages: +2394 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Packages are hard linked from the content-addressable store to the virtual store. Content-addressable store is at: /home/sebasjm/.local/share/pnpm/store/v3 Virtual store is at: node_modules/.pnpm Progress: resolved 2394, reused 2232, downloaded 0, added 2394, done devDependencies: + @babel/core 7.13.16 + @linaria/esbuild 3.0.0-beta.23 + @linaria/shaker 3.0.0-beta.23 + esbuild 0.15.13 + nx 15.0.1 + prettier 2.7.1 packages/idb-bridge prepare$ tsc └─ Done in 5.5s packages/pogen prepare$ tsc └─ Done in 3.5s packages/taler-util prepare$ tsc └─ Done in 5.6s packages/anastasis-core prepare$ tsc └─ Done in 4.6s packages/taler-wallet-core prepare$ tsc └─ Done in 6.2s packages/anastasis-webui prepare$ pnpm compile │ > @gnu-taler/anastasis-webui@0.2.99 compile /home/sebasjm/Work/taler/wal2/packages/anastasis-webui │ > tsc └─ Done in 7s packages/taler-wallet-cli prepare$ tsc && rollup -c │ │ lib/index.js → dist/taler-wallet-cli.mjs... │ (!) Circular dependency │ ../taler-wallet-core/lib/operations/exchanges.js -> ../taler-wallet-core/lib/operations/withdraw.js -> ../taler-wallet-core/lib/o │ created dist/taler-wallet-cli.mjs in 5.4s └─ Done in 14.4s packages/taler-wallet-webextension prepare$ pnpm compile │ > @gnu-taler/taler-wallet-webextension@0.9.0 compile /home/sebasjm/Work/taler/wal2/packages/taler-wallet-webextension │ > tsc && ./build-fast-with-linaria.mjs └─ Done in 18.4s Done in 36.7s |
|
|
After deleting the lockfile and doing "pnpm install", I'm getting this: WARN Issues with peer dependencies found packages/merchant-backend-ui └─┬ @linaria/webpack-loader 3.0.0-beta.22 └─┬ @linaria/webpack5-loader 3.0.0-beta.23 └── ✕ unmet peer webpack@^5.0.0: found 4.46.0 packages/merchant-backoffice-ui └─┬ html-webpack-plugin 5.5.3 └── ✕ unmet peer webpack@^5.20.0: found 4.46.0 The integrity of 8807 files was checked. This might have caused installation to take longer. Done in 1m 14.8s |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-09-05 15:47 | Florian Dold | New Issue | |
| 2022-09-05 15:47 | Florian Dold | Status | new => assigned |
| 2022-09-05 15:47 | Florian Dold | Assigned To | => sebasjm |
| 2022-10-10 18:14 | sebasjm | Note Added: 0019209 | |
| 2022-10-10 18:14 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2022-10-10 18:14 | sebasjm | Status | assigned => feedback |
| 2022-11-01 13:47 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2022-11-01 13:47 | Florian Dold | Status | feedback => assigned |
| 2022-11-01 13:47 | Florian Dold | Note Added: 0019323 | |
| 2022-11-07 22:17 | sebasjm | Note Added: 0019388 | |
| 2022-11-07 22:17 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2022-11-07 22:17 | sebasjm | Status | assigned => feedback |
| 2023-02-20 00:30 | Florian Dold | Target Version | => 0.9.4 |
| 2023-04-13 20:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2023-08-03 21:00 | Florian Dold | Status | feedback => assigned |
| 2023-08-03 21:00 | Florian Dold | Note Added: 0020409 | |
| 2023-08-03 21:00 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2023-09-23 15:58 | Christian Grothoff | Target Version | 0.9.4 => post-1.0 |
