View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007301 | libeufin | General | public | 2022-08-16 10:38 | 2023-02-02 00:25 |
| Reporter | Christian Grothoff | Assigned To | MS | ||
| Priority | low | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Target Version | 0.9.1 | ||||
| Summary | 0007301: 200 OK or 204 No content? | ||||
| Description | Several endpoints in the bank access API are specified to return 200 OK (presumably with an empty JSON object for the body). However, it would likely be better to return 204 No Content and an empty body, as there is nothing to return and we do so elsewhere. As a first step, the cashier should be adjusted to tolerate the new behavior (200 and 204 are both OK), then we can modify libeufin/fakebank to return 204, and then phase-out 200 support. | ||||
| Tags | No tags attached. | ||||
|
|
It looks like current cashier doesn't care as long as the status code is < 300 |
|
|
MS: can you adjust the spec and return 204 with an empty body instead of 200 OK for the endpoints that clearly return 'nothing'? |
|
|
I've now adjusted the spec to include the 204 case. |
|
|
https://docs.taler.net/core/api-wire.html#get-$BASE_URL-history-incoming https://docs.taler.net/core/api-wire.html#get-$BASE_URL-history-outgoing |
|
|
Those links refer to the Taler Wire Gateway API, but the bug was filed initially for the Access API. |
|
|
I'm not sure it was ever supposed to apply to the 'access' API, likely a misunderstanding about the names of the APIs ;-). Looking at your diffs, it seems this one is fixed, right? |
|
|
Closing here, since the TWG got changed as requested. To reduce the risk of breakage for this non critical aspect, other APIs can be changed after the release. 0007587 tracks that. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-16 10:38 | Christian Grothoff | New Issue | |
| 2022-08-16 10:38 | Christian Grothoff | Status | new => assigned |
| 2022-08-16 10:38 | Christian Grothoff | Assigned To | => grote |
| 2022-08-16 10:38 | Christian Grothoff | Priority | normal => low |
| 2022-08-17 20:47 | grote | Note Added: 0019014 | |
| 2022-08-20 23:08 | Christian Grothoff | Assigned To | grote => MS |
| 2022-08-20 23:09 | Christian Grothoff | Note Added: 0019021 | |
| 2022-10-20 11:22 | Christian Grothoff | Target Version | 0.9 => |
| 2023-01-08 10:16 | Christian Grothoff | Note Added: 0019609 | |
| 2023-01-08 10:16 | Christian Grothoff | Project | Taler => libeufin |
| 2023-01-08 10:16 | Christian Grothoff | Category | bank API (C) => General |
| 2023-01-08 11:30 | Christian Grothoff | Target Version | => 0.9.1 |
| 2023-01-12 18:52 | Christian Grothoff | Note Added: 0019639 | |
| 2023-01-13 16:31 | MS | Note Added: 0019660 | |
| 2023-01-14 10:09 | Christian Grothoff | Note Added: 0019664 | |
| 2023-01-14 10:09 | MS | Note Added: 0019665 | |
| 2023-01-14 10:09 | MS | Status | assigned => resolved |
| 2023-01-14 10:09 | MS | Resolution | open => fixed |
| 2023-01-14 10:09 | MS | Note Edited: 0019665 | |
| 2023-02-02 00:25 | Christian Grothoff | Status | resolved => closed |
