View Issue Details

IDProjectCategoryView StatusLast Update
0007300Talerbank API (C)public2023-11-29 01:30
ReporterChristian Grothoff Assigned ToFlorian Dold  
PriorityimmediateSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007300: Taler bank access API does not follow conventions
Descriptionhttps://docs.taler.net/core/api-bank-access.html has camelCase in field names while we use only snail_style in the rest of our APIs.
Furthermore, a date is listed as a string using "// YYYY-MM-DD ending with 'Z'" for the format, which is NOT the date format we use in Taler. And the /config endpoint for API versioning is absent :-(.

Changing this will require coordinated changes to fakebank, libeufin, and cashier.
TagsNo tags attached.

Relationships

related to 0007275 closedChristian Grothoff debit_account / credit_account are highly redundant in bank-api transaction histories 

Activities

MS

2022-09-15 09:27

reporter   ~0019134

As privately discussed, /config now responds at: /demobanks/default/integration-api/config

grote

2023-01-03 15:31

developer   ~0019557

Latest cashier is using this strange URL now. Not sure what else is left here to do.

grote

2023-01-31 18:59

developer   ~0019723

Is there anything left to do for this ticket?

Christian Grothoff

2023-02-02 00:23

manager   ~0019734

I still see camel-case: "accountLabel" and "publicAccounts" and "paytoUri" in the API specs (and more further down). So clearly the camelCase has not been addressed yet. And there is also still "date: string; // milliseconds since the Unix epoch", which isn't _exactly_ how we usually do dates in our API.

Christian Grothoff

2023-09-03 15:38

manager   ~0020484

docs.git:: 898e0199..8df41796 fixes the *specification* to address this issue, but NOT libeufin. Marcello: please fix libeufin ASAP.

MS

2023-11-09 12:20

reporter   ~0020631

Outdated issue, does not apply anymore to the current code.

Issue History

Date Modified Username Field Change
2022-08-16 10:03 Christian Grothoff New Issue
2022-08-16 10:03 Christian Grothoff Status new => assigned
2022-08-16 10:03 Christian Grothoff Assigned To => Christian Grothoff
2022-08-16 10:04 Christian Grothoff Assigned To Christian Grothoff => grote
2022-09-15 09:27 MS Note Added: 0019134
2022-10-20 11:19 Christian Grothoff Target Version 0.9 => 0.9.1
2022-12-20 18:26 Christian Grothoff Target Version 0.9.1 => 0.9.2
2023-01-03 15:31 grote Note Added: 0019557
2023-01-31 18:59 grote Assigned To grote => Christian Grothoff
2023-01-31 18:59 grote Status assigned => feedback
2023-01-31 18:59 grote Note Added: 0019723
2023-02-02 00:23 Christian Grothoff Note Added: 0019734
2023-02-02 00:24 Christian Grothoff Assigned To Christian Grothoff => MS
2023-02-02 00:24 Christian Grothoff Status feedback => assigned
2023-02-17 17:52 Florian Dold Target Version 0.9.2 => 0.9.3
2023-09-03 15:38 Christian Grothoff Note Added: 0020484
2023-09-03 17:36 Christian Grothoff Relationship added related to 0007275
2023-09-03 18:01 Christian Grothoff Priority normal => immediate
2023-09-23 15:02 Christian Grothoff Assigned To MS => Florian Dold
2023-11-09 12:20 MS Status assigned => resolved
2023-11-09 12:20 MS Resolution open => fixed
2023-11-09 12:20 MS Note Added: 0020631
2023-11-29 01:29 Christian Grothoff Fixed in Version => 0.9.3
2023-11-29 01:30 Christian Grothoff Status resolved => closed