View Issue Details

IDProjectCategoryView StatusLast Update
0007190Talermechant backendpublic2022-03-10 01:34
Reporterttn Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformLinuxOSDevuanOS VersionChimaera
Product Versiongit (master) 
Target Version0.9Fixed in Version0.9 
Summary0007190: "make check" fails to build some tests
DescriptionHEAD at 09edba887b8f9f82b1c8cc462ff6faed80d387c8.
Log attached.

(BTW, i'm not really sure that "merchant backend" is the correct category. Please change it as necessary.)
TagsNo tags attached.

Activities

ttn

2022-03-09 12:03

developer  

.ttn.merchant-make-check.log (7,211 bytes)   
+ export PATH=/home/ttn/te/bin:/home/ttn/build/GNU/T/tw-libeufin:/home/ttn/te/bin:/home/ttn/build/GNU/T/tw-taler:/home/ttn/bin:/home/ttn/local/bin:/usr/local/bin:/usr/bin:/bin:/home/ttn/local/share/ttn-do
+ PATH=/home/ttn/te/bin:/home/ttn/build/GNU/T/tw-libeufin:/home/ttn/te/bin:/home/ttn/build/GNU/T/tw-taler:/home/ttn/bin:/home/ttn/local/bin:/usr/local/bin:/usr/bin:/bin:/home/ttn/local/share/ttn-do
+ export TMPDIR=/home/ttn/te/tmp
+ TMPDIR=/home/ttn/te/tmp
+ export PGHOST=/home/ttn/te/pg
+ PGHOST=/home/ttn/te/pg
+ make check
Making check in .
make[1]: ingresso nella directory «/home/ttn/build/GNU/T/merchant»
make[1]: uscita dalla directory «/home/ttn/build/GNU/T/merchant»
Making check in src
make[1]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src»
Making check in include
make[2]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/include»
make[2]: Nessuna operazione da eseguire per «check».
make[2]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/include»
Making check in mustach
make[2]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/mustach»
make  test_mustach_jansson run-original-tests.sh
make[3]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/mustach»
  CC       test_mustach_jansson.o
  CCLD     test_mustach_jansson
make[3]: Nessuna operazione da eseguire per «run-original-tests.sh».
make[3]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/mustach»
make  check-TESTS
make[3]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/mustach»
make[4]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/mustach»
SKIP: run-original-tests.sh
PASS: test_mustach_jansson
============================================================================
Testsuite summary for taler-merchant 0.8.4
============================================================================
# TOTAL: 2
# PASS:  1
# SKIP:  1
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[4]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/mustach»
make[3]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/mustach»
make[2]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/mustach»
Making check in backenddb
make[2]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/backenddb»
make  test-merchantdb-postgres
make[3]: ingresso nella directory «/home/ttn/build/GNU/T/merchant/src/backenddb»
  CC       test_merchantdb.o
test_merchantdb.c: In function ‘make_wire_fee’:
test_merchantdb.c:3281:31: error: ‘struct TALER_MasterWireFeePS’ has no member named ‘wire_fee’
 3281 |   TALER_amount_hton (&fee_sign.wire_fee,
      |                               ^
test_merchantdb.c:3283:31: error: ‘struct TALER_MasterWireFeePS’ has no member named ‘closing_fee’
 3283 |   TALER_amount_hton (&fee_sign.closing_fee,
      |                               ^
test_merchantdb.c: At top level:
test_merchantdb.c:5936:31: warning: ‘struct TALER_PrivateContractHash’ declared inside parameter list will not be visible outside of this definition or declaration
 5936 |                               TALER_PrivateContractHash *h_contract_terms,
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~
test_merchantdb.c: In function ‘test_lookup_refunds_detailed’:
test_merchantdb.c:5952:44: warning: passing argument 3 of ‘plugin->lookup_refunds_detailed’ from incompatible pointer type [-Wincompatible-pointer-types]
 5952 |                                            h_contract_terms,
      |                                            ^~~~~~~~~~~~~~~~
      |                                            |
      |                                            const struct TALER_PrivateContractHash *
test_merchantdb.c:5952:44: note: expected ‘const struct TALER_PrivateContractHashP *’ but argument is of type ‘const struct TALER_PrivateContractHash *’
test_merchantdb.c: In function ‘run_test_refunds’:
test_merchantdb.c:6302:51: warning: passing argument 2 of ‘test_lookup_refunds_detailed’ from incompatible pointer type [-Wincompatible-pointer-types]
 6302 |                                                   &cls->deposits[0].
      |                                                   ^~~~~~~~~~~~~~~~~~
      |                                                   |
      |                                                   struct TALER_PrivateContractHashP *
 6303 |                                                   h_contract_terms,
      |                                                   ~~~~~~~~~~~~~~~~
test_merchantdb.c:44:8: note: in definition of macro ‘TEST_WITH_FAIL_CLAUSE’
   44 |   if ((test)) \
      |        ^~~~
test_merchantdb.c:6301:3: note: in expansion of macro ‘TEST_RET_ON_FAIL’
 6301 |   TEST_RET_ON_FAIL (test_lookup_refunds_detailed (&cls->instance,
      |   ^~~~~~~~~~~~~~~~
test_merchantdb.c:5936:58: note: expected ‘const struct TALER_PrivateContractHash *’ but argument is of type ‘struct TALER_PrivateContractHashP *’
 5935 |                               const struct
      |                               ~~~~~~~~~~~~                
 5936 |                               TALER_PrivateContractHash *h_contract_terms,
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
test_merchantdb.c:6383:51: warning: passing argument 2 of ‘test_lookup_refunds_detailed’ from incompatible pointer type [-Wincompatible-pointer-types]
 6383 |                                                   &cls->deposits[2].
      |                                                   ^~~~~~~~~~~~~~~~~~
      |                                                   |
      |                                                   struct TALER_PrivateContractHashP *
 6384 |                                                   h_contract_terms,
      |                                                   ~~~~~~~~~~~~~~~~
test_merchantdb.c:44:8: note: in definition of macro ‘TEST_WITH_FAIL_CLAUSE’
   44 |   if ((test)) \
      |        ^~~~
test_merchantdb.c:6382:3: note: in expansion of macro ‘TEST_RET_ON_FAIL’
 6382 |   TEST_RET_ON_FAIL (test_lookup_refunds_detailed (&cls->instance,
      |   ^~~~~~~~~~~~~~~~
test_merchantdb.c:5936:58: note: expected ‘const struct TALER_PrivateContractHash *’ but argument is of type ‘struct TALER_PrivateContractHashP *’
 5935 |                               const struct
      |                               ~~~~~~~~~~~~                
 5936 |                               TALER_PrivateContractHash *h_contract_terms,
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
make[3]: *** [Makefile:819: test_merchantdb.o] Errore 1
make[3]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/backenddb»
make[2]: *** [Makefile:1138: check-am] Errore 2
make[2]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src/backenddb»
make[1]: *** [Makefile:413: check-recursive] Errore 1
make[1]: uscita dalla directory «/home/ttn/build/GNU/T/merchant/src»
make: *** [Makefile:473: check-recursive] Errore 1
.ttn.merchant-make-check.log (7,211 bytes)   

Christian Grothoff

2022-03-10 01:34

manager   ~0018785

Fixed in f7985797..59c1318b (2 commits).

Issue History

Date Modified Username Field Change
2022-03-09 12:03 ttn New Issue
2022-03-09 12:03 ttn Status new => assigned
2022-03-09 12:03 ttn Assigned To => Christian Grothoff
2022-03-09 12:03 ttn File Added: .ttn.merchant-make-check.log
2022-03-10 01:34 Christian Grothoff Status assigned => resolved
2022-03-10 01:34 Christian Grothoff Resolution open => fixed
2022-03-10 01:34 Christian Grothoff Fixed in Version => 0.9
2022-03-10 01:34 Christian Grothoff Note Added: 0018785
2022-03-10 01:34 Christian Grothoff Target Version => 0.9