View Issue Details

IDProjectCategoryView StatusLast Update
0007157Talerexchangepublic2022-02-19 21:31
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Versiongit (master) 
Target Version0.9Fixed in Version0.9 
Summary0007157: deposits: consider not allowing wire_transfer_deadline of "never"
DescriptionThe exchange currently allows deposits with wire transfer deadlines of "never".

This doesn't really make sense. Can we reject deposits with unreasonable wire transfer deadlines or at least truncate them to the deposit deadline of the denomination of the coin we're depositing?
TagsNo tags attached.

Activities

Christian Grothoff

2022-02-19 21:31

manager   ~0018702

Fixed in bc3ec563736d28ba73ae4db364086fc30132b730. Note that a 'coin' does not have a deposit deadline, so we cannot truncate to that.

Also, we can only sanely exclude 'forever', as other deadline may make sense. In fact, even 'forever' makes sense, as the transfer would still be triggered when the refund deadline has expired AND the merchant makes another deposit with a non-forever deadline (and aggregation would combine the two and pick the lesser deadline!).

However, most likely a deposit deadline of 'never' is a bug/mistake, and in practice merchants can achieve the same effect by using 100 years into the future or something similarly silly high. So I think forbidding 'never' in mechant API and exchange API is a good thing.

Issue History

Date Modified Username Field Change
2022-01-24 22:19 Florian Dold New Issue
2022-01-24 22:19 Florian Dold Status new => assigned
2022-01-24 22:19 Florian Dold Assigned To => Christian Grothoff
2022-02-19 21:31 Christian Grothoff Status assigned => resolved
2022-02-19 21:31 Christian Grothoff Resolution open => fixed
2022-02-19 21:31 Christian Grothoff Fixed in Version => 0.9
2022-02-19 21:31 Christian Grothoff Note Added: 0018702
2022-02-19 21:31 Christian Grothoff Product Version => git (master)
2022-02-19 21:31 Christian Grothoff Target Version => 0.9