View Issue Details

IDProjectCategoryView StatusLast Update
0007104Talermechant backendpublic2021-11-25 23:43
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Fixed in Version0.9 
Summary0007104: merchant logs a 500 response from the exchange even though a merchant DB error occurred
Descriptionin ..._post-orders-ID-pay.c, we call

      resume_pay_with_error (pc,
                             MHD_HTTP_INTERNAL_SERVER_ERROR,
                             TALER_EC_GENERIC_DB_STORE_FAILED,
                             "deposit");

when we get a hard error from our database. This subsequently causes a log message that makes it *look* like there was an error with the exchange interaction, even when that is not the case.
TagsNo tags attached.

Activities

Christian Grothoff

2021-11-25 23:13

manager   ~0018546

I don't see why you say that. 500 is clearly an internal error, and the EC also points to OUR database. 502/504 are used for exchange errors. The logging is also pretty clear. I'm changing the hint to "insert_deposit" as that is the database interaction. But I don't see what else to do here.

Christian Grothoff

2021-11-25 23:13

manager   ~0018547

2df6e15..17f156a

Florian Dold

2021-11-25 23:25

manager   ~0018549

In resume_pay, we log the following message:

  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Resuming /pay handling as exchange interaction is done (%u)\n",
              response_code);

Thus when the merchant experiences an internal database problem, we log that we got a 500 in an interaction with the exchange. *That's* the confusing part.

Christian Grothoff

2021-11-25 23:43

manager   ~0018552

Well. Read the message: the exchange interaction is done. *OUR* HTTP request status is 500. response_code is always what WE return, not what we got from the exchange. Anyway, I've clarified the log statement in e3e693d..3b9e74b

Issue History

Date Modified Username Field Change
2021-11-23 12:27 Florian Dold New Issue
2021-11-23 12:27 Florian Dold Status new => assigned
2021-11-23 12:27 Florian Dold Assigned To => Christian Grothoff
2021-11-25 23:13 Christian Grothoff Note Added: 0018546
2021-11-25 23:13 Christian Grothoff Status assigned => resolved
2021-11-25 23:13 Christian Grothoff Resolution open => fixed
2021-11-25 23:13 Christian Grothoff Fixed in Version => 0.9
2021-11-25 23:13 Christian Grothoff Note Added: 0018547
2021-11-25 23:25 Florian Dold Note Added: 0018549
2021-11-25 23:25 Florian Dold Status resolved => feedback
2021-11-25 23:25 Florian Dold Resolution fixed => reopened
2021-11-25 23:43 Christian Grothoff Note Added: 0018552
2021-11-25 23:43 Christian Grothoff Status feedback => resolved
2021-11-25 23:43 Christian Grothoff Resolution reopened => fixed