View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007073 | Anastasis | backend | public | 2021-11-05 00:07 | 2023-06-15 17:54 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.3.0 | Fixed in Version | 0.3.0 | ||
| Summary | 0007073: policy payment long polling not documented and too high by default | ||||
| Description | According to CHECK_PAYMENT_GENERIC_TIMEOUT, making a policy upload with an Anastasis-Payment-Identifier waits for 30 minutes (!!) by default. This doesn't seem like a good default. Furthermore, it's not documented anywhere that the POST /policy/$acctid request will actually block when a payment identifier is given. | ||||
| Tags | No tags attached. | ||||
|
|
What is wrong with 30 minutes? After all, we are waiting for the user to do a full bank payment, which even with instant SEPA can be expected to take several minutes. |
|
|
In all our other endpoints, long-polling is not the default, so it probably shouldn't be the default here either. Even if we do long-polling by default, we should not wait for more than ~30 seconds, for reasons outlined here: https://datatracker.ietf.org/doc/html/rfc6202#section-5.5 |
|
|
Fixed in the code and documented in 33152ae..0919fe8 |
|
|
Fix committed to master branch. |
|
anastasis: master 0919fe8b 2021-12-31 19:26 Details Diff |
document and shorten default payment timeout (fixes 0007073) |
Affected Issues 0007073 |
|
| mod - doc/sphinx/rest.rst | Diff File | ||
| mod - src/backend/anastasis-httpd_policy.c | Diff File | ||
| mod - src/backend/anastasis-httpd_policy_upload.c | Diff File | ||
| mod - src/backend/anastasis-httpd_truth.c | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-11-05 00:07 | Florian Dold | New Issue | |
| 2021-11-05 00:07 | Florian Dold | Assigned To | => Christian Grothoff |
| 2021-11-05 00:07 | Florian Dold | Status | new => assigned |
| 2021-11-06 17:36 | Christian Grothoff | Note Added: 0018462 | |
| 2021-11-06 17:36 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2021-11-06 17:36 | Christian Grothoff | Status | assigned => feedback |
| 2021-11-07 17:28 | Florian Dold | Note Added: 0018465 | |
| 2021-12-31 12:40 | Christian Grothoff | Assigned To | Florian Dold => Christian Grothoff |
| 2021-12-31 12:41 | Christian Grothoff | Status | feedback => assigned |
| 2021-12-31 18:27 | Christian Grothoff | Status | assigned => resolved |
| 2021-12-31 18:27 | Christian Grothoff | Resolution | open => fixed |
| 2021-12-31 18:27 | Christian Grothoff | Fixed in Version | => 0.3.0 |
| 2021-12-31 18:27 | Christian Grothoff | Note Added: 0018613 | |
| 2021-12-31 18:27 | Christian Grothoff | Product Version | => Git master |
| 2021-12-31 18:27 | Christian Grothoff | Target Version | => 0.3.0 |
| 2022-09-26 20:50 | Christian Grothoff | Status | resolved => closed |
| 2023-06-15 17:54 | Christian Grothoff | Changeset attached | => anastasis master 0919fe8b |
| 2023-06-15 17:54 | Christian Grothoff | Note Added: 0020276 |
