View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007065 | Anastasis | reducer spec | public | 2021-11-03 12:18 | 2022-09-26 20:50 |
| Reporter | Florian Dold | Assigned To | sebasjm | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.3.0 | Fixed in Version | 0.3.0 | ||
| Summary | 0007065: review types of challenge feedback | ||||
| Description | The possible list of challenge feedback seems excessive. I'm already removing "hint" in favor of "details". But is there a reason to ever allow an arbitrary "body"? We can always add this in the future, but I don't see any reason to let the reducer handle this. A provider returning some response we don't understand should just be considered an error. | ||||
| Tags | No tags attached. | ||||
|
|
The "authentication-timeout" state is also rather unclear. The documentation makes it sound like it should be "authentication-pending"? What's an example where this response can happen? |
|
|
"external-instructions" is way too generic. Why isn't "redirect" an external instruction? The "state" here really should be "auth-iban" or something. |
|
|
Latest reducer API has cleaned up the challenge types a lot. Please let me know if you see anything else amiss -- and update the Typescript implementation to match the latest C edition... |
|
|
The challenge feedback in both reducers is now cleaned up, anastasis-webui doesn't render everything properly yet. |
|
|
unknown challenge feedback status {"state":"incorrect-answer"} -- incorrectly rendered by webui. |
|
|
SM: Please try the various failure modes and make sure the webui handles/renders those nicely... |
|
|
Added a message for every "ChallengeFeedbackStatus" value. There are two places where the feedback is shown: 1.- the policy overview 2.- the challenge detail for [1] messages are defined here https://git.taler.net/wallet-core.git/tree/packages/anastasis-webui/src/pages/home/ChallengeOverviewScreen.tsx#n34 I'm attaching "selection_229" as an example of a policy with challenges in every different state for [2] messages are defined here https://git.taler.net/wallet-core.git/tree/packages/anastasis-webui/src/pages/home/SolveScreen.tsx#n32 I'm attaching "selection_230" where it can be seeing that the feedback is shown as a notification, sometimes as an error (red) or info (blue) |
|
|
at cf894f1dd309e48d8be380c56175219027c84fb7 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-11-03 12:18 | Florian Dold | New Issue | |
| 2021-11-03 12:24 | Florian Dold | Note Added: 0018453 | |
| 2021-11-03 12:31 | Florian Dold | Note Added: 0018454 | |
| 2021-12-31 12:38 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2021-12-31 12:38 | Christian Grothoff | Status | new => assigned |
| 2022-03-10 04:21 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2022-03-10 04:22 | Christian Grothoff | Note Added: 0018789 | |
| 2022-04-14 21:25 | Florian Dold | Note Added: 0018880 | |
| 2022-04-14 21:26 | Christian Grothoff | Product Version | => Git master |
| 2022-04-14 21:26 | Christian Grothoff | Target Version | => 0.3.0 |
| 2022-08-24 12:55 | Christian Grothoff | Note Added: 0019033 | |
| 2022-08-24 13:03 | Christian Grothoff | Assigned To | Florian Dold => sebasjm |
| 2022-08-24 13:04 | Christian Grothoff | Note Added: 0019034 | |
| 2022-08-26 18:09 | sebasjm | Note Added: 0019063 | |
| 2022-08-26 18:09 | sebasjm | File Added: Selection_230.png | |
| 2022-08-26 18:09 | sebasjm | File Added: Selection_229.png | |
| 2022-08-26 18:10 | sebasjm | Status | assigned => resolved |
| 2022-08-26 18:10 | sebasjm | Resolution | open => fixed |
| 2022-08-26 18:10 | sebasjm | Note Added: 0019064 | |
| 2022-09-26 20:49 | Christian Grothoff | Fixed in Version | => 0.3.0 |
| 2022-09-26 20:50 | Christian Grothoff | Status | resolved => closed |