View Issue Details

IDProjectCategoryView StatusLast Update
0007065Anastasisreducer specpublic2022-09-26 20:50
ReporterFlorian Dold Assigned Tosebasjm  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.3.0Fixed in Version0.3.0 
Summary0007065: review types of challenge feedback
DescriptionThe possible list of challenge feedback seems excessive. I'm already removing "hint" in favor of "details".

But is there a reason to ever allow an arbitrary "body"? We can always add this in the future, but I don't see any reason to let the reducer handle this. A provider returning some response we don't understand should just be considered an error.
TagsNo tags attached.


Florian Dold

2021-11-03 12:24

manager   ~0018453

The "authentication-timeout" state is also rather unclear. The documentation makes it sound like it should be "authentication-pending"? What's an example where this response can happen?

Florian Dold

2021-11-03 12:31

manager   ~0018454

"external-instructions" is way too generic. Why isn't "redirect" an external instruction? The "state" here really should be "auth-iban" or something.

Christian Grothoff

2022-03-10 04:22

manager   ~0018789

Latest reducer API has cleaned up the challenge types a lot. Please let me know if you see anything else amiss -- and update the Typescript implementation to match the latest C edition...

Florian Dold

2022-04-14 21:25

manager   ~0018880

The challenge feedback in both reducers is now cleaned up, anastasis-webui doesn't render everything properly yet.

Christian Grothoff

2022-08-24 12:55

manager   ~0019033

unknown challenge feedback status {"state":"incorrect-answer"} -- incorrectly rendered by webui.

Christian Grothoff

2022-08-24 13:04

manager   ~0019034

SM: Please try the various failure modes and make sure the webui handles/renders those nicely...


2022-08-26 18:09

developer   ~0019063

Added a message for every "ChallengeFeedbackStatus" value. There are two places where the feedback is shown:
1.- the policy overview
2.- the challenge detail

for [1] messages are defined here
I'm attaching "selection_229" as an example of a policy with challenges in every different state

for [2] messages are defined here
I'm attaching "selection_230" where it can be seeing that the feedback is shown as a notification, sometimes as an error (red) or info (blue)
Selection_230.png (30,303 bytes)   
Selection_230.png (30,303 bytes)   
Selection_229.png (111,340 bytes)   
Selection_229.png (111,340 bytes)   


2022-08-26 18:10

developer   ~0019064

at cf894f1dd309e48d8be380c56175219027c84fb7

Issue History

Date Modified Username Field Change
2021-11-03 12:18 Florian Dold New Issue
2021-11-03 12:24 Florian Dold Note Added: 0018453
2021-11-03 12:31 Florian Dold Note Added: 0018454
2021-12-31 12:38 Christian Grothoff Assigned To => Christian Grothoff
2021-12-31 12:38 Christian Grothoff Status new => assigned
2022-03-10 04:21 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2022-03-10 04:22 Christian Grothoff Note Added: 0018789
2022-04-14 21:25 Florian Dold Note Added: 0018880
2022-04-14 21:26 Christian Grothoff Product Version => Git master
2022-04-14 21:26 Christian Grothoff Target Version => 0.3.0
2022-08-24 12:55 Christian Grothoff Note Added: 0019033
2022-08-24 13:03 Christian Grothoff Assigned To Florian Dold => sebasjm
2022-08-24 13:04 Christian Grothoff Note Added: 0019034
2022-08-26 18:09 sebasjm Note Added: 0019063
2022-08-26 18:09 sebasjm File Added: Selection_230.png
2022-08-26 18:09 sebasjm File Added: Selection_229.png
2022-08-26 18:10 sebasjm Status assigned => resolved
2022-08-26 18:10 sebasjm Resolution open => fixed
2022-08-26 18:10 sebasjm Note Added: 0019064
2022-09-26 20:49 Christian Grothoff Fixed in Version => 0.3.0
2022-09-26 20:50 Christian Grothoff Status resolved => closed