View Issue Details

IDProjectCategoryView StatusLast Update
0006939Talerexchange API (C)public2021-09-02 18:14
ReporterChristian Grothoff Assigned ToChristian Grothoff  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006939: TALER_JSON_spec_amount should have build-in currency compatibility check
DescriptionInstead of forcing the application logic to always check if the currency is acceptable, we should pass the desired currency into the function (NULL could be passed for "do not care" in case the client supports multiple currencies or does their own check). This way, we can remove a lot of duplicate currency validation logic and also avoid a common failure mode of forgetting to check the currency.
TagsNo tags attached.

Relationships

has duplicate 0006934 closedChristian Grothoff add expected currency to JSON spec parser 

Activities

Christian Grothoff

2021-07-24 09:04

manager   ~0018011

Implemented in exchange, currently breaks the merchant build.

Christian Grothoff

2021-07-24 09:17

manager   ~0018012

Implemented in merchant. Still breaks Anastasis build.

Christian Grothoff

2021-07-24 10:03

manager   ~0018013

Implemented.

Christian Grothoff

2021-09-02 18:14

manager   ~0018225

Fix committed to master branch.

Related Changesets

exchange: master 42decef9

2021-07-24 09:00:35

Christian Grothoff

Details Diff
fix 0006939 in exchange Affected Issues
0006939
mod - src/auditor/taler-auditor-httpd.c Diff File
mod - src/auditor/taler-auditor-httpd.h Diff File
mod - src/auditor/taler-auditor-httpd_deposit-confirmation.c Diff File
mod - src/bank-lib/bank_api_credit.c Diff File
mod - src/bank-lib/bank_api_debit.c Diff File
mod - src/bank-lib/fakebank.c Diff File
mod - src/exchange-tools/taler-auditor-offline.c Diff File
mod - src/exchange-tools/taler-exchange-offline.c Diff File
mod - src/exchange/taler-exchange-httpd_deposit.c Diff File
mod - src/exchange/taler-exchange-httpd_management_wire_fees.c Diff File
mod - src/exchange/taler-exchange-httpd_melt.c Diff File
mod - src/exchange/taler-exchange-httpd_refund.c Diff File
mod - src/include/taler_json_lib.h Diff File
mod - src/json/json_helper.c Diff File
mod - src/json/test_json.c Diff File
mod - src/lib/exchange_api_common.c Diff File
mod - src/lib/exchange_api_deposits_get.c Diff File
mod - src/lib/exchange_api_handle.c Diff File
mod - src/lib/exchange_api_management_get_keys.c Diff File
mod - src/lib/exchange_api_melt.c Diff File
mod - src/lib/exchange_api_refund.c Diff File
mod - src/lib/exchange_api_reserves_get.c Diff File
mod - src/lib/exchange_api_transfers_get.c Diff File
mod - src/lib/exchange_api_wire.c Diff File
mod - src/lib/exchange_api_withdraw2.c Diff File

Issue History

Date Modified Username Field Change
2021-07-23 13:19 Christian Grothoff New Issue
2021-07-23 13:19 Christian Grothoff Status new => assigned
2021-07-23 13:19 Christian Grothoff Assigned To => Christian Grothoff
2021-07-23 14:24 Christian Grothoff Relationship added has duplicate 0006934
2021-07-24 09:04 Christian Grothoff Note Added: 0018011
2021-07-24 09:17 Christian Grothoff Note Added: 0018012
2021-07-24 10:03 Christian Grothoff Status assigned => resolved
2021-07-24 10:03 Christian Grothoff Resolution open => fixed
2021-07-24 10:03 Christian Grothoff Fixed in Version => 0.9
2021-07-24 10:03 Christian Grothoff Note Added: 0018013
2021-07-24 10:03 Christian Grothoff Target Version 0.9.1 => 0.9
2021-07-30 13:57 Christian Grothoff Fixed in Version 0.9 => 0.8.1
2021-07-30 13:59 Christian Grothoff Target Version 0.9 => 0.8.1
2021-07-30 14:01 Christian Grothoff Fixed in Version 0.8.1 => 0.8
2021-07-30 14:02 Christian Grothoff Target Version 0.8.1 => 0.8
2021-08-24 16:22 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master 42decef9
2021-09-02 18:14 Christian Grothoff Note Added: 0018225