View Issue Details

IDProjectCategoryView StatusLast Update
0006677Talermerchant backend API (HTTP specification)public2021-01-07 21:00
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Versiongit (master) 
Target Version0.8.1Fixed in Version0.8.1 
Summary0006677: consider not using 4xx status code when exchange gives 5xx
DescriptionThe merchant currently returns a 424 status code when the exchange reports some transient error, typically a DB conflict.

The status code 424 is a rather specific WebDAV status code, and the merchant should return something in the range of 5xx, as the error here is clearly not the *client*'s responsibility.
TagsNo tags attached.

Activities

Christian Grothoff

2021-01-07 09:50

manager   ~0017320

I think this was placed in the wrong category. Re-assigning.

Christian Grothoff

2021-01-07 21:00

manager   ~0017329

There were two places in the merchant code with HTTP status 424. One was already spec'ed in GANA to be 502, the other in GANA to be 400. I've fixed both, and also adjusted the handling in libtalermerchant (for two other 424s, which already could no longer be generated). api-merchant.rst already never specified 424.

Issue History

Date Modified Username Field Change
2021-01-06 16:32 Florian Dold New Issue
2021-01-06 16:32 Florian Dold Status new => assigned
2021-01-06 16:32 Florian Dold Assigned To => grote
2021-01-07 09:50 Christian Grothoff Note Added: 0017320
2021-01-07 09:50 Christian Grothoff Assigned To grote => Christian Grothoff
2021-01-07 09:51 Christian Grothoff Category cashier (Android App) => merchant backend API (HTTP specification)
2021-01-07 09:51 Christian Grothoff Product Version => git (master)
2021-01-07 09:51 Christian Grothoff Target Version => 0.8.1
2021-01-07 21:00 Christian Grothoff Status assigned => resolved
2021-01-07 21:00 Christian Grothoff Resolution open => fixed
2021-01-07 21:00 Christian Grothoff Fixed in Version => 0.9
2021-01-07 21:00 Christian Grothoff Note Added: 0017329
2021-01-07 21:00 Christian Grothoff Fixed in Version 0.9 => 0.8.1