View Issue Details

IDProjectCategoryView StatusLast Update
0006665Talerexchangepublic2021-09-02 18:14
Reporterttn Assigned ToChristian Grothoff  
PriorityurgentSeverityblockReproducibilityhave not tried
Status closedResolutionfixed 
PlatformLinuxOSDevuanOS VersionBeowulf/Chimaera
Target Version0.8Fixed in Version0.8 
Summary0006665: FTBFS: missing header taler_testing_lib.h
DescriptionFrom a fresh taler-exchange-0.8.1.tar.gz, unpacked and did:

    $ configure -C --with-gnunet=/usr/local
    $ make

I attach the full `make` output, which ends with:

      CC testing_api_cmd_rewind.lo
    testing_api_cmd_rewind.c:27:10: fatal error: taler/taler_testing_lib.h: File o directory non esistente
       27 | #include "taler/taler_testing_lib.h"
          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
Additional InformationThis build attempt is in the context of stabilizing the Taler Merchant Manual,
which requires first building and installing GNUnet (no issues), then Exchange
(the current problem), then Merchant (still to go).
TagsNo tags attached.
Attached Files
.ttn.make.log (10,908 bytes)   

Activities

ttn

2020-12-09 02:43

developer   ~0017173

I notice that the erroneous line:

    https://git.taler.net/exchange.git/tree/src/testing/testing_api_cmd_rewind.c#n27

is followed by one very similar. So i comment out line 27, and re-issue the `make` command.
It successfully compiles that file and continues until another similar "File or directory non-existent"
error later on (full log attached).
.ttn.make-2.log (6,677 bytes)   

ttn

2020-12-09 02:55

developer   ~0017174

I notice the erroneous line (this time):

  https://git.taler.net/exchange.git/tree/src/testing/testing_api_trait_uuid.c#n25

and the following two lines have the same subdir component, namely, "taler/"
and furthermore use the "system" (angle-bracket) syntax, so i change that portion
of the file to look like:

    //#include <taler/taler_signatures.h>
    //#include <taler/taler_exchange_service.h>
    //#include <taler/taler_testing_lib.h>
    #include "taler_signatures.h"
    #include "taler_exchange_service.h"
    #include "taler_testing_lib.h"

(essentially: removing the prefix subdir and changing the syntax
to "local"). I re-issued `make` and this time it succeeded (went to
completion w/o further error).

ttn

2020-12-09 03:06

developer   ~0017175

I'd like to commit these changes to the Git repo.
Is there a branch besides **master** that i can push to
for review (since this would be my first non-documentation commit,
i'd like a second opinion to make sure i'm on the right track)?

Or would people prefer to make some other change to resolve this issue?

ttn

2020-12-09 03:22

developer   ~0017176

(When i accidentally pushed branch ''p'' to docs.git, i remember there was
an error message saying something like: "Only SOMETHING can be deleted
by non-admin users". What is that SOMETHING ?!?)

ttn

2020-12-09 05:19

developer   ~0017177

PTAL commit 289cf01c8ab2054933b9b67408fe04f221aaf0b1:
https://git.taler.net/exchange.git/commit/?h=dev/ttn/fix-6665&id=289cf01c8ab2054933b9b67408fe04f221aaf0b1

Christian Grothoff

2020-12-09 07:27

manager   ~0017179

I've fixed this and related places in Git master. You are also welcome to push such changes directly to master. Here there was really no reason to review.

One thing: the bug is masked if you immediately run 'make install' (or if you have run 'make install' in the past...).

Christian Grothoff

2021-09-02 18:14

manager   ~0018243

Fix committed to master branch.

Related Changesets

exchange: master 9911b327

2020-12-09 08:25

Christian Grothoff


Details Diff
fix 0006665 Affected Issues
0006665
mod - contrib/gana Diff File
mod - src/testing/test_bank_api_twisted.c Diff File
mod - src/testing/testing_api_cmd_rewind.c Diff File
mod - src/testing/testing_api_cmd_twister_exec_client.c Diff File
mod - src/testing/testing_api_trait_uuid.c Diff File

Issue History

Date Modified Username Field Change
2020-12-09 02:14 ttn New Issue
2020-12-09 02:14 ttn Status new => assigned
2020-12-09 02:14 ttn Assigned To => Christian Grothoff
2020-12-09 02:14 ttn File Added: .ttn.make.log
2020-12-09 02:43 ttn Note Added: 0017173
2020-12-09 02:43 ttn File Added: .ttn.make-2.log
2020-12-09 02:55 ttn Note Added: 0017174
2020-12-09 03:06 ttn Note Added: 0017175
2020-12-09 03:22 ttn Note Added: 0017176
2020-12-09 05:19 ttn Note Added: 0017177
2020-12-09 07:27 Christian Grothoff Note Added: 0017179
2020-12-09 07:28 Christian Grothoff Assigned To Christian Grothoff => ttn
2020-12-09 07:28 Christian Grothoff Status assigned => resolved
2020-12-09 07:28 Christian Grothoff Resolution open => fixed
2020-12-09 07:28 Christian Grothoff Fixed in Version => 0.9
2020-12-09 07:28 Christian Grothoff Target Version => 0.9
2021-07-30 13:57 Christian Grothoff Fixed in Version 0.9 => 0.8.1
2021-07-30 13:59 Christian Grothoff Target Version 0.9 => 0.8.1
2021-07-30 14:02 Christian Grothoff Fixed in Version 0.8.1 => 0.8
2021-07-30 14:02 Christian Grothoff Target Version 0.8.1 => 0.8
2021-08-24 16:23 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master 9911b327
2021-09-02 18:14 Christian Grothoff Note Added: 0018243
2021-09-02 18:14 Christian Grothoff Assigned To ttn => Christian Grothoff