View Issue Details

IDProjectCategoryView StatusLast Update
0006520Talerotherpublic2020-08-24 14:55
ReporterFlorian Dold Assigned To 
PrioritylowSeverityfeatureReproducibilityalways
Status acknowledgedResolutionopen 
Product Versiongit (master) 
Summary0006520: GANA doesn't complain when error names are re-used with a new code, but it results in a compilation error
DescriptionGANA should try to only generate headers that actually compile!

When we repeat the name of an error code, only the C/TS/etc. compiler will catch this, but not the "make" inside the GANA repo that generates these files via templating.
TagsNo tags attached.

Activities

Christian Grothoff

2020-08-24 13:06

manager   ~0016735

Eh, I tested, and GANA does complain properly *if* you run 'make check'.

Christian Grothoff

2020-08-24 13:07

manager   ~0016736

And 'check' is part of 'make all', so I'm not sure what you did to NOT get this error:

$ make check
recfix --check registry.rec
registry.rec:125: error: %constraint[0] violated in record
make: *** [Makefile:9: check] Error 1

[after manually introducing a problem as described]

Florian Dold

2020-08-24 14:05

manager   ~0016737

I've committed a broken registry here, to a branch:

https://git.gnunet.org/gana.git/commit/?h=dev/dold/broken-registry&id=57ea691b13f689e29d66192c7c22cc2b41349e6c

For me, this happens:
$ cd gnu-taler-error-codes
$ make check
recfix --check registry.rec
(exits with status 0)

Here's my recutils version:
$ recfix --version
recfix (GNU recutils) 1.8.90

Christian Grothoff

2020-08-24 14:10

manager   ~0016738

C'est bizzare! I tested with duplicate NAMEs just like you did, and 'make check' hated me as it should. But with your change, it is indeed breaking.

Christian Grothoff

2020-08-24 14:11

manager   ~0016739

Contacted jemarch via IRC, let's see what he says.

Christian Grothoff

2020-08-24 14:54

manager   ~0016745

jemarch says this is not supported. Maybe we'll get a feature update in the future ;-).

Issue History

Date Modified Username Field Change
2020-08-24 08:15 Florian Dold New Issue
2020-08-24 13:06 Christian Grothoff Note Added: 0016735
2020-08-24 13:07 Christian Grothoff Note Added: 0016736
2020-08-24 13:08 Christian Grothoff Assigned To => Florian Dold
2020-08-24 13:08 Christian Grothoff Status new => feedback
2020-08-24 14:05 Florian Dold Note Added: 0016737
2020-08-24 14:10 Christian Grothoff Note Added: 0016738
2020-08-24 14:11 Christian Grothoff Note Added: 0016739
2020-08-24 14:54 Christian Grothoff Note Added: 0016745
2020-08-24 14:55 Christian Grothoff Assigned To Florian Dold =>
2020-08-24 14:55 Christian Grothoff Priority normal => low
2020-08-24 14:55 Christian Grothoff Severity minor => feature
2020-08-24 14:55 Christian Grothoff Reproducibility have not tried => always
2020-08-24 14:55 Christian Grothoff Status feedback => acknowledged
2020-08-24 14:55 Christian Grothoff Product Version => git (master)