View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006367 | libeufin | libeufin-nexus | public | 2020-06-08 16:55 | 2023-01-08 10:33 |
| Reporter | MS | Assigned To | Florian Dold | ||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.0 | Fixed in Version | 0.9.0 | ||
| Summary | 0006367: improve the way payments aren't submitted more than once | ||||
| Description | The current code marks a payments as submitted BEFORE submitting it, therefore if the program stops executing between the flagging and the actual submission, then such payment will NEVER be submitted. Happens here: https://git.taler.net/libeufin.git/tree/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt?id=1656ff8ac1ff4a70121b8ae67933a165b3dfa516#n408 | ||||
| Tags | No tags attached. | ||||
|
|
The real condition to stop submitting a payment is when it never got confirmed by the bank as a outgoing transaction (or clearly after such confirmation arrives). But at the same time, the payment should not get submitted again until one of the two conditions above happens. So this flagging is not completely wrong, I would say. |
|
|
It's not bad to submit a payment multiple times as its ID will be the same and the bank will just ignore it. |
|
|
Payments are not marked as submitted *after* submitting them. Furthermore, we tested with GLS: The combination of (messageID, paymentInformationId) is used for de-duplication. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-06-08 16:55 | MS | New Issue | |
| 2020-06-12 17:13 | MS | Priority | normal => high |
| 2020-06-17 12:14 | MS | Note Added: 0016291 | |
| 2020-06-17 12:14 | MS | Note Edited: 0016291 | |
| 2020-06-17 12:17 | MS | Note Edited: 0016291 | |
| 2020-06-17 14:11 | MS | Note Added: 0016292 | |
| 2020-06-18 21:50 | Florian Dold | Assigned To | => Florian Dold |
| 2020-06-18 21:50 | Florian Dold | Status | new => resolved |
| 2020-06-18 21:50 | Florian Dold | Resolution | open => fixed |
| 2020-06-18 21:50 | Florian Dold | Note Added: 0016303 | |
| 2023-01-08 10:32 | Christian Grothoff | Fixed in Version | => 0.9.0 |
| 2023-01-08 10:32 | Christian Grothoff | Target Version | => 0.9.0 |
| 2023-01-08 10:33 | Christian Grothoff | Status | resolved => closed |
| 2023-04-13 20:38 | Florian Dold | Category | nexus => libeufin-nexus |
