View Issue Details

IDProjectCategoryView StatusLast Update
0006367libeufinnexuspublic2020-06-18 21:50
ReporterMS Assigned ToFlorian Dold  
PriorityhighSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Summary0006367: improve the way payments aren't submitted more than once
DescriptionThe current code marks a payments as submitted BEFORE submitting it, therefore if the program stops executing between the flagging and the actual submission, then such payment will NEVER be submitted.

Happens here:
https://git.taler.net/libeufin.git/tree/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt?id=1656ff8ac1ff4a70121b8ae67933a165b3dfa516#n408
TagsNo tags attached.

Activities

MS

2020-06-17 12:14

manager   ~0016291

Last edited: 2020-06-17 12:17

The real condition to stop submitting a payment is when it never got confirmed by the bank as a outgoing transaction (or clearly after such confirmation arrives). But at the same time, the payment should not get submitted again until one of the two conditions above happens.

So this flagging is not completely wrong, I would say.

MS

2020-06-17 14:11

manager   ~0016292

It's not bad to submit a payment multiple times as its ID will be the same and the bank will just ignore it.

Florian Dold

2020-06-18 21:50

manager   ~0016303

Payments are not marked as submitted *after* submitting them.

Furthermore, we tested with GLS: The combination of (messageID, paymentInformationId) is used for de-duplication.

Issue History

Date Modified Username Field Change
2020-06-08 16:55 MS New Issue
2020-06-12 17:13 MS Priority normal => high
2020-06-17 12:14 MS Note Added: 0016291
2020-06-17 12:14 MS Note Edited: 0016291
2020-06-17 12:17 MS Note Edited: 0016291
2020-06-17 14:11 MS Note Added: 0016292
2020-06-18 21:50 Florian Dold Assigned To => Florian Dold
2020-06-18 21:50 Florian Dold Status new => resolved
2020-06-18 21:50 Florian Dold Resolution open => fixed
2020-06-18 21:50 Florian Dold Note Added: 0016303