View Issue Details

IDProjectCategoryView StatusLast Update
0006213Talerexchangepublic2021-09-02 18:14
Reporteroec Assigned ToChristian Grothoff  
PrioritylowSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.7.1Fixed in Version0.7.1 
Summary0006213: Better description of TALER_amount.fraction
DescriptionIn exchange/src/include/taler_amount_lib.h, TALER_amount is declared to have the following member:

 102 /**
 103 * Fraction (denominator of fraction)
 104 */
 105 uint32_t fraction;

I find "denominator" misleading. A value of 1 and a fraction of 2 is not an amount 1/2 but 1+2*TALER_AMOUNT_FRAC_BASE

I suggest to change the description to "Fraction (integer multiples of TALER_AMOUNT_FRAC_BASE)"
TagsNo tags attached.

Activities

Christian Grothoff

2020-04-23 12:04

manager   ~0015756

Comment updated in 727eccbe..0774fd70, also gave the full formula with #TALER_AMOUNT_FRAC_BASE desciption.

Christian Grothoff

2021-09-02 18:14

manager   ~0018257

Fix committed to master branch.

Related Changesets

exchange: master 0774fd70

2020-04-23 13:59

Christian Grothoff


Details Diff
fix 0006213 Affected Issues
0006213
mod - src/include/taler_amount_lib.h Diff File

Issue History

Date Modified Username Field Change
2020-04-23 11:17 oec New Issue
2020-04-23 11:17 oec Status new => assigned
2020-04-23 11:17 oec Assigned To => Christian Grothoff
2020-04-23 12:04 Christian Grothoff Note Added: 0015756
2020-04-23 12:04 Christian Grothoff Status assigned => resolved
2020-04-23 12:04 Christian Grothoff Resolution open => fixed
2020-04-23 12:04 Christian Grothoff Fixed in Version => 0.7.1
2020-04-23 12:04 Christian Grothoff Product Version => git (master)
2020-04-23 12:04 Christian Grothoff Target Version => 0.7.1
2021-08-24 16:23 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master 0774fd70
2021-09-02 18:14 Christian Grothoff Note Added: 0018257