View Issue Details

IDProjectCategoryView StatusLast Update
0006193Talerexchangepublic2021-09-02 18:14
Reporterfefe Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version0.7.0 
Target Version0.7.1Fixed in Version0.7.1 
Summary0006193: memset for clearing key material
DescriptionIn exchange/src/lib/exchange_api_refresh_common.c:

 65 /* Finally, clean up a bit...
 66 (NOTE: compilers might optimize this away, so this is
 67 not providing any strong assurances that the key material
 68 is purged.) */
 69 memset (md,
 70 0,
 71 sizeof (struct MeltData));

glibc now has a function called explicit_bzero for this (since version 2.25 from Feb 2017).
TagsNo tags attached.

Activities

Christian Grothoff

2020-04-21 14:49

manager   ~0015723

Ja, ist nur dann eben nicht so portabel. Die groessere Frage fuer mich ist, ob wir key-clearing ueberhaupt machen sollten...

Christian Grothoff

2020-04-21 14:56

manager   ~0015724

GNUNET_CRYPTO_zero_keys() macht bereits explicit_bzero(), sollten wir hier also verwenden.

Christian Grothoff

2020-04-21 14:57

manager   ~0015725

Fixed in c167fd8f..ee0d0dd3

Christian Grothoff

2021-09-02 18:14

manager   ~0018260

Fix committed to master branch.

Related Changesets

exchange: master ee0d0dd3

2020-04-21 16:53

Christian Grothoff


Details Diff
fix 0006193 Affected Issues
0006193
mod - src/lib/exchange_api_refresh_common.c Diff File

Issue History

Date Modified Username Field Change
2020-04-21 14:38 fefe New Issue
2020-04-21 14:38 fefe Status new => assigned
2020-04-21 14:38 fefe Assigned To => Christian Grothoff
2020-04-21 14:49 Christian Grothoff Note Added: 0015723
2020-04-21 14:56 Christian Grothoff Note Added: 0015724
2020-04-21 14:57 Christian Grothoff Note Added: 0015725
2020-04-21 14:58 Christian Grothoff Status assigned => resolved
2020-04-21 14:58 Christian Grothoff Resolution open => fixed
2020-04-21 14:58 Christian Grothoff Fixed in Version => 0.7.1
2020-04-21 14:58 Christian Grothoff Target Version => 0.7.1
2021-08-24 16:23 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master ee0d0dd3
2021-09-02 18:14 Christian Grothoff Note Added: 0018260