View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006096 | Taler | wallet (WebExtension) | public | 2020-02-17 15:56 | 2022-11-04 20:52 |
| Reporter | Florian Dold | Assigned To | sebasjm | ||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.9 | Fixed in Version | 0.9 | ||
| Summary | 0006096: wallet should render complete contract terms | ||||
| Description | Currently the browser wallet only renders a tiny subset of the contract terms. It should instead support rendering the full contract schema in a user-friendly way. The schema is documented here: https://docs.taler.net/core/api-merchant.html#the-contract-terms | ||||
| Tags | No tags attached. | ||||
|
|
Assigning to Sebastian, as he's already working on the contract terms rendering for the backoffice UI. |
|
|
Documents showing a first design iteration are available at: https://git.taler.net/large-media.git/tree/issue_6096 There is a set of wireframes and a video. A clickable prototype is also available at https://www.figma.com/proto/GuGZzjPTqYKhQnapfeG8s4/Taler-web-extension?node-id=25%3A3&scaling=min-zoom&page-id=25%3A2&starting-point-node-id=25%3A3 |
|
|
After some discussion about iteration 1 of the design, we concluded it would be better to hide the terms of service upon acceptance, so that the withdrawal details remain in view when you click the "confirm withdrawal" button. Documents showing the second design iteration are available at: https://git.taler.net/large-media.git/tree/issue_6096/iteration_2 There is a set of wireframes and a video. The clickable prototype is available at: https://www.figma.com/proto/GuGZzjPTqYKhQnapfeG8s4/Taler-web-extension?node-id=25%3A3&scaling=min-zoom&page-id=25%3A2&starting-point-node-id=25%3A3 |
|
|
In order to get the terms of service information the wallet will be making a request here [1] Documentation of the exchange setup here [2] says that terms it's optional for some server (like when it's not production) so we should consider in the design a message when there is no terms of service or when the terms of service is available in other formats. The defaults (reading the exchange server code) seems to be xml, which may or may not be parsable by the browser. [1] https://docs.taler.net/core/api-exchange.html#get--terms [2] https://docs.taler.net/taler-exchange-manual.html#terms-of-service |
|
|
seems that there is not enough information. for the record: found getExchangeWithdrawalInfo but was not externalized, seems the correct way to get this info @Florian Dold fix awful spelling :) |
|
|
@belen, I've pushed changes that can be reviewed on sotrybook for the design impl and the testing example or with the latest version against test environment |
|
|
I've pulled, and the changes I see seem to be about displaying the exchange terms of service. Is this what you needed me to look at? |
|
|
Yes, I have implemented the design that share here https://bugs.gnunet.org/view.php?id=6096#c18057 Since this is about the terms of service we can follow any feedback in this issue https://bugs.gnunet.org/view.php?id=5983 I will keep this issue open in order to design and implement the contract terms view |
|
|
to be shown by default * payment deadline (before payment) * delivery date and location * products (summary) we should add an "view more details" with all the information possible of the contract terms. |
|
|
fixed at 7a600514c6d43bbaeba6b962533415e59fc46057 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-02-17 15:56 | Florian Dold | New Issue | |
| 2020-02-17 15:56 | Florian Dold | Status | new => assigned |
| 2020-02-17 15:56 | Florian Dold | Assigned To | => Florian Dold |
| 2020-09-11 22:57 | Christian Grothoff | Severity | minor => feature |
| 2020-09-11 22:57 | Christian Grothoff | Product Version | => git (master) |
| 2020-09-11 22:57 | Christian Grothoff | Target Version | => 0.8.1 |
| 2021-06-15 19:07 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2021-06-15 19:08 | Florian Dold | Note Added: 0017955 | |
| 2021-08-02 16:41 | belen | Note Added: 0018050 | |
| 2021-08-03 17:28 | belen | Note Added: 0018057 | |
| 2021-08-24 20:39 | Christian Grothoff | Target Version | => 0.8.5 |
| 2021-09-07 14:13 | sebasjm | Note Added: 0018389 | |
| 2021-09-08 18:17 | sebasjm | Note Added: 0018390 | |
| 2021-09-08 18:24 | sebasjm | Note Edited: 0018390 | |
| 2021-09-08 18:53 | sebasjm | Note Edited: 0018390 | |
| 2021-09-13 20:41 | sebasjm | Note Added: 0018392 | |
| 2021-09-13 20:45 | sebasjm | Assigned To | sebasjm => belen |
| 2021-09-17 17:18 | belen | Note Added: 0018395 | |
| 2021-09-17 18:38 | sebasjm | Relationship added | related to 0005983 |
| 2021-09-18 22:57 | sebasjm | Note Added: 0018397 | |
| 2022-07-17 17:15 | Christian Grothoff | Assigned To | belen => sebasjm |
| 2022-07-17 17:17 | sebasjm | Note Added: 0018959 | |
| 2022-08-08 19:12 | sebasjm | Status | assigned => resolved |
| 2022-08-08 19:12 | sebasjm | Resolution | open => fixed |
| 2022-08-08 19:12 | sebasjm | Fixed in Version | => git (master) |
| 2022-08-08 19:12 | sebasjm | Note Added: 0018998 | |
| 2022-10-20 10:45 | Christian Grothoff | Target Version | 0.8.5 => 0.9 |
| 2022-10-20 10:48 | Christian Grothoff | Fixed in Version | git (master) => 0.9 |
| 2022-11-04 20:52 | Christian Grothoff | Status | resolved => closed |
| 2023-04-13 20:37 | Florian Dold | Category | wallet (WebExtensions) => wallet (WebExtension) |
