View Issue Details

IDProjectCategoryView StatusLast Update
0005887Talerexchangepublic2020-01-09 13:43
ReporterMarcello StanisciAssigned ToMarcello Stanisci 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Versiongit (master) 
Target Version0.6.1Fixed in Version0.6.1 
Summary0005887: Order tests under bank-lib/
DescriptionThe codebase got bloated by a combination of tests, namely each test has multiple "flavours": "_with_fakebank", "_new", "_with_pybank", and possibly others. We should, first of all, discard the old-style tests (the ones not using libtalertesting), and then condensate all the logic in one source file that runs once against fakebank and once against pybank.
TagsNo tags attached.

Activities

Marcello Stanisci

2019-09-11 00:54

manager   ~0014882

Last edited: 2019-09-11 00:55

View 2 revisions

The condensation happened (ee6d7d75..e362c786), there is one file for non-twisted tests (test_bank_api_new.c) and one for twisted ones (test_bank_api_twisted.c). Now old tests need to be either discarded, or integrated into the new ones.

Marcello Stanisci

2020-01-09 13:15

manager   ~0015259

test_bank_api_new.c *was* renamed as test_bank_api.c, therefore old tests got discarded; closing

Issue History

Date Modified Username Field Change
2019-09-10 12:56 Marcello Stanisci New Issue
2019-09-10 12:56 Marcello Stanisci Status new => assigned
2019-09-10 12:56 Marcello Stanisci Assigned To => Christian Grothoff
2019-09-10 12:57 Marcello Stanisci Assigned To Christian Grothoff =>
2019-09-11 00:54 Marcello Stanisci Note Added: 0014882
2019-09-11 00:55 Marcello Stanisci Note Edited: 0014882 View Revisions
2019-09-16 09:26 Christian Grothoff Assigned To => Marcello Stanisci
2020-01-09 13:15 Marcello Stanisci Note Added: 0015259
2020-01-09 13:15 Marcello Stanisci Status assigned => resolved
2020-01-09 13:15 Marcello Stanisci Resolution open => fixed
2020-01-09 13:43 Christian Grothoff Product Version => git (master)
2020-01-09 13:43 Christian Grothoff Fixed in Version => 0.6.1
2020-01-09 13:43 Christian Grothoff Target Version => 0.6.1