View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005704||Taler||Web site(s)||public||2019-04-26 20:21||2019-06-10 14:36|
|Priority||normal||Severity||tweak||Reproducibility||have not tried|
|Product Version||SVN HEAD|
|Target Version||Fixed in Version|
|Summary||0005704: Create common base template|
|Description||To share the commonalities of all the demo pages (Introduction/Landing, Bank, Essay Shop, Donations, Tipping/Survey) a base template should be included in the web-common repo that all individual templates can inherit from.|
|Tags||No tags attached.|
||Development is happening in the branch feature/common-base-template of the repo web-common.|
||Development is happening in the branch dev/lukas-grossberger/common-base-template in the relevant frontend repos.|
Would someone be so kind to have a look at my modifications to the "Makefile.am" in web-common's dev/lukas-grossberger/common-base-template? I'm completely new to makefiles and think I failed to adjust it to reflect the new directory structure with ccs/ js/ and template/ sub directories, because the hierarchical builds that create and trigger a makefile for web-common fail with errors like for landing:
> make: *** No rule to make target 'taler-wallet-lib.js', needed by 'all-am'. Stop.
ng0 was right (on the mailinglist). I've shown you how to do this in 29c609f..c145e27
That said, with this change *all* configure.ac scripts that use the new structure must also be updated. Basically, you'll find at the bottom of the configure.ac a call to AC_OUTPUT([FOO BAR web-common/Makefile]). To that list, we now need to add "web-common/css/Makefile" and "web-common/js/Makefile".
||Thanks, Christian. I got it to work together with the matching feature branch in the landing repo. I'll follow that example in the other places as well.|
When trying to port flask powered repos like donations to the common template, "url( ... )" can't be used in templates but instead "url_for('static', filename=' ... ')" has to be used for static files.
Next, try to figure out if "url_for" can be used everywhere, or whether there needs to / can be an alias for "url( ... )" in the jinja context that points to the static equivalent for the flask case.
|2019-04-26 20:21||LUG||New Issue|
|2019-04-26 20:22||LUG||Note Added: 0014350|
|2019-04-27 10:22||LUG||Note Added: 0014354|
|2019-04-27 15:23||LUG||Note Added: 0014355|
|2019-05-02 15:21||Christian Grothoff||Note Added: 0014375|
|2019-05-02 15:22||Christian Grothoff||Assigned To||=> LUG|
|2019-05-02 15:22||Christian Grothoff||Status||new => assigned|
|2019-05-02 15:22||Christian Grothoff||Severity||minor => tweak|
|2019-05-02 15:22||Christian Grothoff||Product Version||=> SVN HEAD|
|2019-05-02 22:02||LUG||Note Added: 0014378|
|2019-06-10 14:36||LUG||Note Added: 0014526|