View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005685Talerexchangepublic2019-04-08 20:112019-04-10 13:25
Reporternikita Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.5 
Target Version0.6Fixed in Version0.6 
Summary0005685: test_exchangedb.c gnunet_memcmp refactoring question
DescriptionIn ./src/exchangedb/test_exchangedb.c, function check_refresh_reveal_cb,
is it appropriate to replace the last memcmp with GNUNET_memcmp (in line ~440 (lines number
might differ I have unpushed changed))?

GNUNET_assert (0 ==
                             memcmp (tprivs,
                                              tprivsr,
                                              sizeof (struct TALER_TransferPrivateKeyP) * (TALER_CNC_KAPPA - 1)));

tprivsr is const struct TALER_TransferPrivateKeyP,
tprivs is static struct TALER_TransferPrivateKeyP.
TagsNo tags attached.

Activities

Christian Grothoff

2019-04-08 21:59

manager   ~0014277

Yes, there the old memcmp has to stay, as we're comparing arrays.

nikita

2019-04-08 22:12

reporter   ~0014278

Hm, I see.

Issue History

Date Modified Username Field Change
2019-04-08 20:11 nikita New Issue
2019-04-08 20:11 nikita Status new => assigned
2019-04-08 20:11 nikita Assigned To => Christian Grothoff
2019-04-08 21:59 Christian Grothoff Note Added: 0014277
2019-04-08 22:12 nikita Note Added: 0014278
2019-04-10 13:24 Christian Grothoff Status assigned => closed
2019-04-10 13:24 Christian Grothoff Resolution open => fixed
2019-04-10 13:24 Christian Grothoff Fixed in Version => 0.6
2019-04-10 13:25 Christian Grothoff Product Version => 0.5
2019-04-10 13:25 Christian Grothoff Target Version => 0.6