View Issue Details

IDProjectCategoryView StatusLast Update
0005622GNUnetutil librarypublic2019-03-12 09:11
ReporterschanzenAssigned Toschanzen 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.11.0 
Target Version0.11.1Fixed in Version 
Summary0005622: gnunet-qr.py is incorrectly installed under bin/
DescriptionAny file in bin/ should be executable. gnunet-qr.py is a python script without shebang.
Package managers like homebrew will nag if you do this: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/38723/version=high_sierra/console

I guess one solution would be to install gnunet-qr.py under prefix/share/gnunet.
TagsNo tags attached.

Activities

schanzen

2019-03-02 14:24

developer   ~0014120

Moved script to pkgshare in e61aefb0d3e54a4f008aaad4776be2f8db4e9fb0

ng0

2019-03-04 00:14

developer   ~0014137

I will test if this is enough to make pkgsrc shut up as well.
If it works out this closes this bug.

ng0

2019-03-11 22:41

developer   ~0014181

Where should this be located?
It's nowhere to be found in share/ in new installs.
So clearly there's something overlooked here.

schanzen

2019-03-11 22:55

developer   ~0014182

Can you be more specific in your comments? What is _this_? _What_ is not located in share?
I gave you the change and the commit in the comment. You can simply look it up.
The python script is now installed in pkgshare. I do not know where your pkgshare is. For me it is <prefix>/share/gnunet.
The shell script is setup accordingly.
And if you need a hotpatch for packaging, you can look at https://github.com/Homebrew/homebrew-core/blob/master/Formula/gnunet.rb

schanzen

2019-03-11 23:04

developer   ~0014183

I see. It seems I forgot to add it to pkgdir. Strange.

schanzen

2019-03-11 23:08

developer   ~0014184

Added in 53dc65ceef37c049fbf2378d351c4596394521e1

ng0

2019-03-11 23:36

developer   ~0014185

Thanks!

Looks solved to me, I will reopen if against all odds it isn't.
Feel free to close and add it to the 0.11.1 roadmap.

Issue History

Date Modified Username Field Change
2019-03-02 13:56 schanzen New Issue
2019-03-02 14:24 schanzen Assigned To => schanzen
2019-03-02 14:24 schanzen Status new => feedback
2019-03-02 14:24 schanzen Note Added: 0014120
2019-03-04 00:14 ng0 Note Added: 0014137
2019-03-04 00:14 ng0 Assigned To schanzen => ng0
2019-03-11 22:41 ng0 Note Added: 0014181
2019-03-11 22:41 ng0 Assigned To ng0 => schanzen
2019-03-11 22:55 schanzen Note Added: 0014182
2019-03-11 23:04 schanzen Note Added: 0014183
2019-03-11 23:08 schanzen Note Added: 0014184
2019-03-11 23:36 ng0 Note Added: 0014185
2019-03-12 09:11 schanzen Status feedback => resolved
2019-03-12 09:11 schanzen Resolution open => fixed