View Issue Details

IDProjectCategoryView StatusLast Update
0005602GNUnetstatistics servicepublic2019-05-04 12:05
Reporterng0Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status newResolutionopen 
Platformamd64OSNetBSDOS VersionCURRENT
Product Version 
Target VersionFixed in Version 
Summary0005602: test_gnunet_statistics.py fails when DEBUG=1 is exported before make check is run
DescriptionThis is okay:

PATH=$PATH:/home/ng0/src/gnunet/gnunet:/home/ng0/opt/bin TMP=/tmp GNUNET_PREFIX=/home/ng0/opt make check

This is not:

PATH=$PATH:/home/ng0/src/gnunet/gnunet:/home/ng0/opt/bin TMP=/tmp GNUNET_PREFIX=/home/ng0/opt make check

2nd one trips on the test and log outputs:

=======================================================
   gnunet 0.11.0pre66: src/statistics/test-suite.log
=======================================================

# TOTAL: 5
# PASS: 4
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test_gnunet_statistics.py
===============================

Preparing: Starting service...
Traceback (most recent call last):
  File "./test_gnunet_statistics.py", line 89, in <module>
    t = r_arm(['-s'], want_stdo=False)
  File "./test_gnunet_statistics.py", line 61, in r_arm
    rc, stdo, stde = sub_run(run_arm + extra_args, **kw)
  File "./test_gnunet_statistics.py", line 46, in sub_run
    p = subprocess.Popen(args, stdout=stdo, stderr=stde)
  File "/usr/pkg/lib/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/pkg/lib/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not list
FAIL test_gnunet_statistics.py (exit status: 1)

Additional InformationIt is unlikely someone will trigger this in release, but I think it should be fixed nevertheless.
TagsNo tags attached.

Activities

Christian Grothoff

2019-03-02 08:31

manager   ~0014112

I do not see a difference between the line that is supposed to be "OK" and the one that is not. Also, setting DEBUG=1 does nothing on my system for the tests.

Christian Grothoff

2019-03-02 08:32

manager   ~0014113

Oh, wait, the py test did not run on my sys for some reason.

Christian Grothoff

2019-03-02 08:41

manager   ~0014114

I can reproduce this now, but looking at the code and the documentation of subprocess.Popen(), I cannot fathom what is going wrong. The docs says we should pass a sequence, and we pass a list which provides sequence.

dvn

2019-05-03 23:34

developer   ~0014380

I also do not see the difference between the "OK" line, and the "NOT OKAY" line...

Grothoff, you say you are able to reproduce - can you share the way you are going about reproducing this?

Christian Grothoff

2019-05-04 12:05

manager   ~0014381

As the report says:

cd gnunet/src/statistics/
$ export DEBUG=1
$ make check

PASS: test_statistics_api
PASS: test_statistics_api_loop
PASS: test_statistics_api_watch
PASS: test_statistics_api_watch_zero_value
FAIL: test_gnunet_statistics.py
$ cat test_gnunet_statistics.py.log
Preparing: Starting service...
Traceback (most recent call last):
  File "./test_gnunet_statistics.py", line 89, in <module>
    t = r_arm(['-s'], want_stdo=False)
  File "./test_gnunet_statistics.py", line 61, in r_arm
    rc, stdo, stde = sub_run(run_arm + extra_args, **kw)
  File "./test_gnunet_statistics.py", line 46, in sub_run
    p = subprocess.Popen(args, stdout=stdo, stderr=stde)
  File "/usr/lib/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.7/subprocess.py", line 1453, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not list
FAIL test_gnunet_statistics.py (exit status: 1)

Issue History

Date Modified Username Field Change
2019-02-22 21:33 ng0 New Issue
2019-03-02 08:31 Christian Grothoff Note Added: 0014112
2019-03-02 08:32 Christian Grothoff Note Added: 0014113
2019-03-02 08:41 Christian Grothoff Note Added: 0014114
2019-05-03 23:34 dvn Note Added: 0014380
2019-05-04 12:05 Christian Grothoff Note Added: 0014381