View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005525 | gnunet-www | General | public | 2019-01-27 16:21 | 2021-09-08 21:50 |
| Reporter | nikita | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | assigned | Resolution | open | ||
| Target Version | 2022-01 | ||||
| Summary | 0005525: new website: Firefox Reader Mode does not display all of our pages in full | ||||
| Description | * Layout / CSS: - Firefox Reader Mode does not display all of our pages in full. Essentially fix that. | ||||
| Tags | website | ||||
| Attached Files | |||||
|
|
I understand that a button to activate the reader mode should appear in the url bar in Firefox, when such mode is available But such button appears in no page in the site, so I can't activate the reader mode in no page in the site I can't reproduce this ¯\_(ツ)_/¯ |
|
|
Which version of Firefox is that? I can reproduce this (this -> my report) in 52 and 65 (65 currently being unavailable for me). |
|
|
This (appended, or at https://d.n0.is/pub/jpg/2019-01-30-104803_1920x1080_scrot.png) is https://stage.gnunet.org with firefox52-52.9.0nb12 from pkgsrc HEAD. |
|
|
strange the button to activate the reader mode does show up in the on line version (stage.gnunet.org ) but it doesn't in the version that I built locally I'll have to figure this out too I use Firefox 64.x |
|
|
It does not work for local pages, 11668829 firefox bug is open for over 4 years and unassigned: https://bugzilla.mozilla.org/show_bug.cgi?id=1166829 |
|
|
It remains to be tested if a local python webserver would be considered "local" as well. |
|
|
Ah ok. How do I run a local python server ? Is a server embedded in this setup ? |
|
|
If you find out the way it works in Jinja2, document it. I can't look into it at the moment. I know python(2,3) has a webserver out of the box: https://www.pythonforbeginners.com/modules-in-python/how-to-use-simplehttpserver/ assumption: jinja2 has something similar. So far this wasn't necessary. But reader mode, I'm not sure if this is this important. How many people use this? I usually don't. |
|
|
For what it's worth, I'll add that I use reader mode often. I believe the fact this is not rendering the page properly is also an indication that screen readers (eg. for the blind) would not be able to parse the full page either. Which is a more severe problem. |
|
|
Yes, if those are the implications. |
|
|
I know why this happens, at least I think so: we totally disregard the hierarchy of h1, h2 etc and some other elements. edit: this was wrong, but what one of the Accessibility checkers spit out. I'm going to think about the right fix. |
|
|
Try one of our pages with for example https://achecker.ca |
|
|
Here's a workaround for the stage not building, and local reader mode not being a thing for security reasons: https://d.n0.is/pub/doc/gnunet/www/en/ updates automatically. |
|
|
Since I was wondering how reader mode decides when to display what and I am not well enough on my feet again to read its code, here's some more insight into reader mode which might help us: https://stackoverflow.com/questions/30661650/how-does-firefox-reader-view-operate |
|
|
I understand enough of what triggers reader mode now, assigning to myself. |
|
|
The gist of it is contained in https://stackoverflow.com/questions/30661650/how-does-firefox-reader-view-operate https://support.mozilla.org/en-US/questions/1140969 and changes I already made to our website. We should eventually standardize the layout. I'm no longer actively working on this, will eventually pick it back up. If you feel like working on it, go ahead. |
|
|
I fixed accessibility problems, header issues (3x h1!), lack of article/section markings. All of these were suggested in the posts quoted by ng0, albeit still readability mode looks like shit for the front page ;-( |
|
|
Thanks! With the alt tag you've done too much in places (or just one?). I've read into this, there's a range of images which should not get alt tags. For example the branding logo. |
|
|
quoting https://support.siteimprove.com/hc/en-gb/articles/115000013031-Accessibility-Image-Alt-text-best-practices Alt text for decorative images Decorative images are images that serve no specific purpose, meaning that they are not meant to convey any meaning or important information. In this case, it is best practice to use what is called the NULL alt text or empty alt text. <img alt=""> (two quotation marks after the alt=) Note that the alt attribute is still present, even though it is empty. When a screen reader comes across null alt text, it will completely skip over the image, without announcing its presence. If no alt attribute is present, the screen reader will read the file name for the image instead, which can be a major distraction to those using screen reading technology. |
|
|
As it is a link back to the front page (and the only one!), I'm not sure it qualifies as purely decorative. |
|
|
Okay, agreed. But also this is progress and learning, there's no definite end to when accessibility is 100%. In my opinion the current navigation bar image is bad. really bad. It doesn't work out. A text version would be better (taking the gnu:net from the big logo). |
|
|
For your information, a couple of days ago I made a commit where you can run the website in a python3 local webserver but it is necessary to navigate to the en/ (or any other folder) manually. `make run` does this now. This means you can debug readermode stuff without the site being on a webserver. |
|
|
Most pages are fixed, but our general layout (for example on the index page) is still an issue for reader mode. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-01-27 16:21 | nikita | New Issue | |
| 2019-01-27 16:22 | nikita | Summary | Firefox Reader Mode does not display all of our pages in full => new website: Firefox Reader Mode does not display all of our pages in full |
| 2019-01-29 16:00 | catonano | Tag Attached: website | |
| 2019-01-30 02:49 | catonano | Note Added: 0013516 | |
| 2019-01-30 11:47 | nikita | Note Added: 0013517 | |
| 2019-01-30 11:49 | nikita | File Added: 2019-01-30-104803_1920x1080_scrot.png | |
| 2019-01-30 11:49 | nikita | Note Added: 0013518 | |
| 2019-01-30 11:51 | nikita | Note Edited: 0013518 | |
| 2019-01-30 19:37 | nikita | Category | other => webpage |
| 2019-01-30 19:37 | nikita | Target Version | => 0.11.0 |
| 2019-01-31 06:40 | catonano | Note Added: 0013530 | |
| 2019-01-31 16:45 | nikita | Note Added: 0013533 | |
| 2019-01-31 16:46 | nikita | Note Added: 0013534 | |
| 2019-01-31 17:12 | catonano | Note Added: 0013535 | |
| 2019-01-31 17:50 | nikita | Note Added: 0013536 | |
| 2019-01-31 17:50 | nikita | Status | new => acknowledged |
| 2019-02-04 00:56 | Christian Grothoff | Product Version | => Git master |
| 2019-02-04 00:56 | Christian Grothoff | Target Version | 0.11.0 => 0.11.1 |
| 2019-02-04 20:10 | dvn | Note Added: 0013595 | |
| 2019-02-06 14:41 | nikita | Note Added: 0013611 | |
| 2019-02-06 14:44 | nikita | Note Added: 0013612 | |
| 2019-02-06 14:47 | nikita | Note Added: 0013613 | |
| 2019-02-06 15:02 | nikita | Note Edited: 0013612 | |
| 2019-02-06 16:01 | nikita | Note Added: 0013615 | |
| 2019-02-06 16:15 | nikita | Note Added: 0013616 | |
| 2019-02-06 19:05 | nikita | Assigned To | => nikita |
| 2019-02-06 19:05 | nikita | Status | acknowledged => assigned |
| 2019-02-06 19:06 | nikita | Note Added: 0013617 | |
| 2019-02-24 00:52 | nikita | Note Added: 0013975 | |
| 2019-02-24 00:52 | nikita | Assigned To | nikita => |
| 2019-02-24 13:28 | Christian Grothoff | Note Added: 0014003 | |
| 2019-02-24 14:57 | nikita | Note Added: 0014010 | |
| 2019-02-24 14:58 | nikita | Note Added: 0014011 | |
| 2019-02-24 14:59 | nikita | Note Edited: 0014011 | |
| 2019-02-24 15:21 | Christian Grothoff | Note Added: 0014015 | |
| 2019-02-24 15:32 | nikita | Note Added: 0014018 | |
| 2019-02-27 17:58 | nikita | Note Added: 0014094 | |
| 2019-02-27 17:59 | nikita | Note Edited: 0014094 | |
| 2019-04-01 14:16 | nikita | Note Added: 0014245 | |
| 2019-04-03 12:16 | Christian Grothoff | Target Version | 0.11.1 => |
| 2019-04-04 16:00 | nikita | Assigned To | => nikita |
| 2019-07-28 15:50 | nikita | Assigned To | nikita => |
| 2020-10-29 11:34 | schanzen | Project | GNUnet => gnunet-www |
| 2020-10-29 11:34 | schanzen | Category | webpage => General |
| 2020-10-29 11:36 | schanzen | Target Version | => 2021-01 |
| 2021-03-12 16:42 | schanzen | Target Version | 2021-01 => 2021-02 |
| 2021-09-08 21:50 | schanzen | Target Version | 2021-02 => 2022-01 |
