View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005179 | GNUnet | other | public | 2017-11-19 11:45 | 2018-06-07 00:24 |
| Reporter | nikita | Assigned To | nikita | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | won't fix | ||
| Summary | 0005179: Update python scripts to python 3 | ||||
| Description | At the moment a good amount (if not all) of these scripts is using python 2. We should update them to python 3 (probably 3.5, the 2to3-3.5 tool can be helpful in addition to reference manuals). In the long run, once rustc can be bootstrapped through mrustc and not rustc itself, I'm considering to rewrite them in rust. | ||||
| Additional Information | ./contrib/terminate.py.in ./contrib/gnunet_janitor.py.in ./contrib/pydiffer.py.in ./contrib/gnunet_pyexpect.py.in ./src/peerinfo-tool/test_gnunet_peerinfo.py.in ./src/dht/test_dht_tools.py.in ./src/arm/test_gnunet_arm.py.in ./src/fs/test_gnunet_fs_idx.py.in ./src/fs/test_gnunet_fs_psd.py.in ./src/fs/test_gnunet_fs_rec.py.in ./src/integration-tests/test_integration_disconnect_nat.py.in ./src/integration-tests/test_integration_bootstrap_and_connect.py.in ./src/integration-tests/test_integration_reconnect_nat.py.in ./src/integration-tests/test_integration_clique.py.in ./src/integration-tests/test_integration_reconnect.py.in ./src/integration-tests/gnunet_pyexpect.py.in ./src/integration-tests/gnunet_testing.py.in ./src/integration-tests/test_integration_disconnect.py.in ./src/revocation/test_local_revocation.py.in ./src/testbed/buildvars.py.in ./src/statistics/test_gnunet_statistics.py.in ./src/util/gnunet-qr.py.in ./contrib/ps_mem.py ./contrib/gnunet-chk.py ./contrib/find_typedefs.py ./contrib/gdb-iterate-dll.py ./src/consensus/consensus-simulation.py | ||||
| Tags | No tags attached. | ||||
|
|
The upstream of contrib/ps_mem.py has moved to its own package: https://github.com/pixelb/ps_mem/ with an setup.py Where is this file needed, if at all (grep shows only self reference)? |
|
|
If I find no in-GNUnet source user of ps_mem, I'm dropping it while working on the branch to update python2 to python3. I think we should not keep things in contrib that are distributed elsewhere now. |
|
|
After successfully porting to python3, I'll replace all these tests with test written in pytest. I was told that with "py.test you could throw away all of the helper functions in that file and it will produce better output." We can write compact testcases this way and more useful failure messages. Once I have rewritten it, Hypothesis (a python module) can also help getting better tests with less code. (It's advanced QuickCheck with support for stateful interaction). |
|
|
I'm closing this as the original issue "update from py2 to py3" will never be finished. I'm implementing a pytest based testsuite soon. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-11-19 11:45 | nikita | New Issue | |
| 2017-11-19 16:08 | nikita | Note Added: 0012584 | |
| 2017-11-19 16:13 | nikita | Description Updated | |
| 2017-11-20 20:14 | nikita | Assigned To | => nikita |
| 2017-11-20 20:14 | nikita | Status | new => assigned |
| 2017-11-20 20:16 | nikita | Note Added: 0012593 | |
| 2017-11-25 11:26 | nikita | Note Added: 0012598 | |
| 2018-01-03 18:07 | nikita | Status | assigned => resolved |
| 2018-01-03 18:07 | nikita | Resolution | open => won't fix |
| 2018-01-03 18:07 | nikita | Note Added: 0012715 | |
| 2018-06-07 00:24 | Christian Grothoff | Status | resolved => closed |
