View Issue Details

IDProjectCategoryView StatusLast Update
0005098TalerWeb site(s)public2020-01-20 15:24
ReporterMarcello StanisciAssigned Tong0 
PrioritynormalSeveritytweakReproducibilityhave not tried
Status resolvedResolutionreopened 
Product Versiongit (master) 
Target Version0.7Fixed in Version 
Summary0005098: --prefix option would be useful
DescriptionGiven that now it is a BB worker which builds the site, it needs to copy all the
HTML/CSS/static files in a separate directory. The woker does that becasue it wipes the local checkout before building the site, and that erases useful files too. So the useful files are to be copied in a safer place.

A './confifure --prefix' option would save the BB worker from manually copying HTML/CSS/static file into the safer place.
TagsNo tags attached.

Relationships

related to 0005055 closedMarcello Stanisci website updates (www, www-stage, docs) should go into buildbot and not into cron 

Activities

ng0

2019-07-15 19:18

developer   ~0014683

Ack, will get to this after GSoC.

Florian Dold

2019-08-29 22:55

manager   ~0014823

I don't think --prefix is the right way to do this.

Websites that are served with python are already packaged like normal python packages, either installed globally or per-user. There's nothing more we need to do there.

For websites that have just static files, the build system should produce a "dist" dir that contains all the files, and we then just need to copy this one directory instead of collecting together files manually. No need to complicate things with a --prefix argument and an "install" process that just copies data.

ng0

2019-09-02 09:54

developer   ~0014833

Okay, this is what I did with gnunet.org

ng0

2019-09-03 16:55

developer   ~0014841

I've switched the sh file used in the job for stage to copy file from the directory 'rendered' which contains all files (similar to how gnunet.org should be build once we have a buildbot doing this). Is this what you wanted, Marcello?

Florian Dold

2019-11-01 23:22

manager   ~0015047

I've actually revised my opinion on this issue. The landing.git repository already supports --prefix, and www.git should do so too.

The main reason why I changed opinion on this matter is that we now have the taler-build-scripts.git, which makes setting up the build system to do this much easier and uniform across repositories.

ng0

2019-12-14 13:54

developer   ~0015155

This is satisfied by recent config.mk and the install rule in www.git as far as I can see.
running make install would mkdir and then cp to the prefix/share/taler-www

Florian Dold

2019-12-14 13:58

manager   ~0015157

Looks good to me.

ng0

2019-12-14 15:45

developer   ~0015159

It's still not fixed, i need to work in the right path into the Makefile of www. Will close when done.

ng0

2019-12-14 16:04

developer   ~0015160

instead of "hopping around" for stable/master, why don't we use a git worktree for one of the branches? this way we just have to cd to the directory and get rid of conflicting state (better would be to build in a different way)

Florian Dold

2019-12-14 16:06

manager   ~0015161

Not sure what you mean. We already have to separate checkouts for master and stable. Git's worktrees just allow us to have to branches checked out in some sub-folder of the same cloned repo.

ng0

2019-12-14 16:19

developer   ~0015162

Okay.
Then deployment really needs better documentation, I'm just going by buildbot logs.

Christian Grothoff

2019-12-25 12:05

manager   ~0015221

Why is this bug still open? Seems to work...

ng0

2020-01-20 15:24

developer   ~0015292

I haven't done any bug triage recently. Closing as implemented.

Issue History

Date Modified Username Field Change
2017-06-29 11:29 Marcello Stanisci New Issue
2017-06-29 11:29 Marcello Stanisci Relationship added related to 0005055
2017-10-23 10:23 Christian Grothoff Severity minor => tweak
2017-10-23 10:23 Christian Grothoff Product Version => git (master)
2017-10-23 10:53 Christian Grothoff Status new => confirmed
2017-12-14 15:58 Christian Grothoff Target Version => 0.7
2019-07-15 19:18 ng0 Note Added: 0014683
2019-07-15 19:18 ng0 Assigned To => ng0
2019-07-15 19:18 ng0 Status confirmed => assigned
2019-08-29 22:55 Florian Dold Note Added: 0014823
2019-09-02 09:54 ng0 Note Added: 0014833
2019-09-03 16:55 ng0 Note Added: 0014841
2019-09-03 16:55 ng0 Assigned To ng0 => Marcello Stanisci
2019-11-01 23:22 Florian Dold Note Added: 0015047
2019-11-01 23:22 Florian Dold Assigned To Marcello Stanisci => ng0
2019-12-14 13:54 ng0 Note Added: 0015155
2019-12-14 13:58 Florian Dold Status assigned => resolved
2019-12-14 13:58 Florian Dold Resolution open => fixed
2019-12-14 13:58 Florian Dold Note Added: 0015157
2019-12-14 15:45 ng0 Status resolved => feedback
2019-12-14 15:45 ng0 Resolution fixed => reopened
2019-12-14 15:45 ng0 Note Added: 0015159
2019-12-14 16:04 ng0 Note Added: 0015160
2019-12-14 16:06 Florian Dold Note Added: 0015161
2019-12-14 16:19 ng0 Note Added: 0015162
2019-12-25 12:05 Christian Grothoff Note Added: 0015221
2020-01-20 15:24 ng0 Status feedback => resolved
2020-01-20 15:24 ng0 Note Added: 0015292