View Issue Details

IDProjectCategoryView StatusLast Update
0004445Talerexchangepublic2016-04-24 23:42
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004445: ftbfs on a fresh debian jessie
Descriptionconfigure doesn't complain, but apparently there's something wrong with lib(gn|c)url.
Additional Information  CC plugin_wire_test.lo
In file included from ../../src/include/taler_bank_service.h:26:0,
                 from plugin_wire_test.c:24:
/usr/local/include/gnunet/gnunet_curl_lib.h:141:22: error: unknown type name 'CURL'
                      CURL *eh,
                      ^
TagsNo tags attached.

Activities

Florian Dold

2016-04-19 14:08

manager   ~0010513

Last edited: 2016-04-19 14:09

This might be related to how platform.h is handled, it was included (both in GNUnet and in the Taler exchange) in some places where it shouldn't be included (namely public headers).

gnunet/platform.h includes the gnunet configuration header, which shares some of the same #defines as the taler exchange configuration header (but the code in configure.ac for setting those flags is not the same). Thus we might have included the wrong file in some places.

Florian Dold

2016-04-19 14:38

manager   ~0010514

Okay, so here's the problem:

// gnunet_curl_lib.h
#if HAVE_CURL_CURL_H
#include <curl/curl.h>
#elif HAVE_GNURL_CURL_H
#include <gnurl/curl.h>
#else
// I've added this error
#error "needs curl or gnurl"
#endif


we basically assume that HAVE_(GN|C)URL_CURL_H is defined before we include the header. So in the exchange, we need to include our platform header before including gnunet_curl_lib.

Florian Dold

2016-04-19 15:14

manager   ~0010517

fixed by changing the taler exchange configure.ac (also fixed some includes in GNUnet)

Christian Grothoff

2016-04-24 23:42

manager   ~0010554

Please report Git revisions in which bugs are resolved.

Issue History

Date Modified Username Field Change
2016-04-19 13:18 Florian Dold New Issue
2016-04-19 13:18 Florian Dold Status new => assigned
2016-04-19 13:18 Florian Dold Assigned To => Christian Grothoff
2016-04-19 14:08 Florian Dold Note Added: 0010513
2016-04-19 14:09 Florian Dold Note Edited: 0010513
2016-04-19 14:09 Florian Dold Note Edited: 0010513
2016-04-19 14:38 Florian Dold Note Added: 0010514
2016-04-19 15:14 Florian Dold Note Added: 0010517
2016-04-19 15:14 Florian Dold Status assigned => resolved
2016-04-19 15:14 Florian Dold Resolution open => fixed
2016-04-24 23:42 Christian Grothoff Note Added: 0010554
2016-04-24 23:42 Christian Grothoff Status resolved => closed
2016-04-24 23:42 Christian Grothoff Product Version => 0.0
2016-04-24 23:42 Christian Grothoff Fixed in Version => 0.0
2016-04-24 23:42 Christian Grothoff Target Version => 0.0