View Issue Details

IDProjectCategoryView StatusLast Update
0004422Talerobsolete componentpublic2016-04-15 17:14
ReporterChristian Grothoff Assigned ToFlorian Dold  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004422: taler-bank-manage createdb fails (substitution error?)
Descriptiongrothoff@spec:~$ taler-bank-manage createdb
2016-04-15 15:55:40,398 settings INFO secret key not configured in TALER_BANK_SECRET_KEY env variable, generating random secret
psql: FATAL: database "@dbnamefinal@" does not exist
TagsNo tags attached.

Activities

Christian Grothoff

2016-04-15 15:59

manager   ~0010480

Also, while we're at it, maybe the --with-dbname configure option (which I did NOT set in the run above) should be replaced with a config option in config.d/, as we do with everything else?

Florian Dold

2016-04-15 16:07

manager   ~0010483

You're right about the database name, it should be read from the config, I'll fix that.

I'm wondering though, should creation of the database be in taler-bank-manage anyway? At least on my system, I have to add additional permissions with psql, since my user can't actually create databases (by default).

I don't think other components of Taler create the database themselves, just the tables, right?

Florian Dold

2016-04-15 16:12

manager   ~0010484

In 3bc4d61, the database name is now read from the [bank]database config option.

I'd be in favour of just removing createdb, it's not consistent with the rest of taler, and requires guessing the system configuration (it won't work if only the postgres user can create databases).

Christian Grothoff

2016-04-15 16:40

manager   ~0010486

I'm fine with removing the option. We might want to consider just trying to automatically create it if we can, and otherwise prompt the user to run 'createdb'.

Florian Dold

2016-04-15 17:11

manager   ~0010490

In most cases the user needs to manually create the database with permissions anyway, and the exchange/merchant requires the same procedure.

At least for now, we shouldn't try to create the db automatically.

Issue History

Date Modified Username Field Change
2016-04-15 15:57 Christian Grothoff New Issue
2016-04-15 15:57 Christian Grothoff Status new => assigned
2016-04-15 15:57 Christian Grothoff Assigned To => Florian Dold
2016-04-15 15:59 Christian Grothoff Note Added: 0010480
2016-04-15 16:07 Florian Dold Note Added: 0010483
2016-04-15 16:07 Florian Dold Status assigned => feedback
2016-04-15 16:12 Florian Dold Note Added: 0010484
2016-04-15 16:40 Christian Grothoff Note Added: 0010486
2016-04-15 16:40 Christian Grothoff Status feedback => assigned
2016-04-15 17:11 Florian Dold Note Added: 0010490
2016-04-15 17:11 Florian Dold Status assigned => resolved
2016-04-15 17:11 Florian Dold Resolution open => fixed
2016-04-15 17:14 Christian Grothoff Status resolved => closed
2016-04-15 17:14 Christian Grothoff Fixed in Version => 0.0
2022-08-23 20:26 Christian Grothoff Category bank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 01:23 Christian Grothoff Category py bank (demonstrator, obsolete) => obsolete componet
2023-12-11 20:08 Florian Dold Category obsolete componet => obsolete component