View Issue Details

IDProjectCategoryView StatusLast Update
0004184Talerexchangepublic2021-09-02 18:14
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritylowSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004184: inconsistent naming: expire_spend vs expire_deposit
DescriptionThose two have the same meaning, one is used in the C code and the other one in the /keys JSON. One should be renamed to the other.
TagsNo tags attached.

Activities

Christian Grothoff

2016-02-18 15:43

manager   ~0010151

Yes and no. We do use "spend" for wallet->merchant and "deposit" for merchant->exchange. So depending on context, the different terms may even make sense, but of course they correspond to the same event/deadline in the end. Maybe we need a third term?

Christian Grothoff

2016-05-02 05:12

manager   ~0010593

Fixed by renaming to expire_deposit in 1c2be59..b98a204

Christian Grothoff

2021-09-02 18:14

manager   ~0018314

Fix committed to master branch.

Related Changesets

exchange: master b98a2045

2016-05-02 07:10

Christian Grothoff


Details Diff
fix 0004184 Affected Issues
0004184
mod - src/exchange-lib/exchange_api_handle.c Diff File
mod - src/exchange-lib/exchange_api_refresh.c Diff File
mod - src/exchange-tools/taler-auditor-sign.c Diff File
mod - src/exchange-tools/taler-exchange-keycheck.c Diff File
mod - src/exchange-tools/taler-exchange-keyup.c Diff File
mod - src/exchange/taler-exchange-httpd_keystate.c Diff File
mod - src/exchangedb/perf_taler_exchangedb_init.c Diff File
mod - src/exchangedb/plugin_exchangedb_postgres.c Diff File
mod - src/exchangedb/test_exchangedb.c Diff File
mod - src/include/taler_exchange_service.h Diff File
mod - src/include/taler_signatures.h Diff File

Issue History

Date Modified Username Field Change
2016-02-18 15:40 Florian Dold New Issue
2016-02-18 15:40 Florian Dold Status new => assigned
2016-02-18 15:40 Florian Dold Assigned To => Christian Grothoff
2016-02-18 15:43 Christian Grothoff Note Added: 0010151
2016-02-18 15:43 Christian Grothoff Status assigned => feedback
2016-02-18 15:43 Christian Grothoff Category mint => exchange
2016-02-19 21:38 Christian Grothoff Product Version => 0.0
2016-02-19 21:38 Christian Grothoff Target Version => 0.1
2016-02-20 02:14 Christian Grothoff Severity trivial => text
2016-03-20 21:53 Torsten Grothoff Issue cloned: 0004289
2016-05-02 05:12 Christian Grothoff Note Added: 0010593
2016-05-02 05:12 Christian Grothoff Status feedback => resolved
2016-05-02 05:12 Christian Grothoff Fixed in Version => 0.0
2016-05-02 05:12 Christian Grothoff Resolution open => fixed
2016-05-02 05:12 Christian Grothoff Target Version 0.1 => 0.0
2016-05-02 05:12 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master b98a2045
2021-09-02 18:14 Christian Grothoff Note Added: 0018314