View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004059 | GNUnet | file-sharing service | public | 2015-11-18 15:57 | 2018-06-07 00:24 |
| Reporter | amatus | Assigned To | amatus | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | Git master | ||||
| Target Version | 0.11.0pre66 | Fixed in Version | 0.11.0pre66 | ||
| Summary | 0004059: GNUNET_FS_ProgressCallback return value documentation doesn't match search_result_suspend behaviour | ||||
| Description | The GNUNET_FS_ProgressCallback documentation for the return value says that it should be NULL for SUSPEND. * @return client-context (for the next progress call * for this operation; should be set to NULL for * SUSPEND and STOPPED events). The value returned * will be passed to future callbacks in the respective * field in the `struct GNUNET_FS_ProgressInfo`. But when search_result_suspend makes a search status call, it asserts that the return value is non-NULL: if (0 == sr->mandatory_missing) { /* client is aware of search result, notify about suspension event */ pi.status = GNUNET_FS_STATUS_SEARCH_RESULT_SUSPEND; pi.value.search.specifics.result_suspend.cctx = sr->client_info; pi.value.search.specifics.result_suspend.meta = sr->meta; pi.value.search.specifics.result_suspend.uri = sr->uri; sr->client_info = GNUNET_FS_search_make_status_ (&pi, sc->h, sc); } GNUNET_break (NULL == sr->client_info); | ||||
| Steps To Reproduce | 08:39 < zPlus> amatus: if I set a timeout task to stop a scheduled search after S seconds, I get "ERROR Assertion failed at fs_search.c:1725" when the search stops. Or, if I Ctrl+C at any time, the search stops with this message "ERROR Assertion failed at fs_search.c:1519" | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-11-18 15:57 | amatus | New Issue | |
| 2015-11-18 15:59 | amatus | Note Added: 0009926 | |
| 2015-11-18 15:59 | amatus | Status | new => resolved |
| 2015-11-18 15:59 | amatus | Resolution | open => no change required |
| 2017-02-26 02:19 | Christian Grothoff | Assigned To | => amatus |
| 2017-02-26 02:19 | Christian Grothoff | Fixed in Version | => 0.11.0pre66 |
| 2017-02-26 02:19 | Christian Grothoff | Target Version | => 0.11.0pre66 |
| 2018-06-07 00:24 | Christian Grothoff | Status | resolved => closed |
