View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003893 | libmicrohttpd | HTTPS (TLS) | public | 2015-07-14 22:30 | 2021-09-02 17:54 |
Reporter | matwey | Assigned To | Christian Grothoff | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 0.9.42 | ||||
Target Version | 0.9.43 | Fixed in Version | 0.9.43 | ||
Summary | 0003893: CURL_SSLVERSION_TLSv1_1 is used when libcurl > 7.16.4 is required | ||||
Description | Unit test in testcurl/https/test_https_session_info.c uses CURL_SSLVERSION_TLSv1_1 which is came from libcurl > 7.34 At the same time configure.ac requires libcurl to be > 7.16.4. Attempts to compile tests with libcurl between 7.16.4 and 7.34 lead to compile failure. Attached here is a patch to introduce compile time guards with respect to libcurl version used. | ||||
Tags | No tags attached. | ||||
Attached Files | libmicrohttpd_test_session.patch (963 bytes)
Index: libmicrohttpd-0.9.42/src/testcurl/https/test_https_session_info.c =================================================================== --- libmicrohttpd-0.9.42.orig/src/testcurl/https/test_https_session_info.c +++ libmicrohttpd-0.9.42/src/testcurl/https/test_https_session_info.c @@ -90,6 +90,7 @@ query_session_ahc (void *cls, struct MHD /** * negotiate a secure connection with server & query negotiated security parameters */ +#if LIBCURL_VERSION_NUM >= 0x072200 static int test_query_session () { @@ -161,7 +162,7 @@ test_query_session () free (cbc.buf); return 0; } - +#endif int main (int argc, char *const *argv) @@ -177,7 +178,9 @@ main (int argc, char *const *argv) fprintf (stderr, "Error (code: %u)\n", errorCount); return -1; } +#if LIBCURL_VERSION_NUM >= 0x072200 errorCount += test_query_session (); +#endif print_test_result (errorCount, argv[0]); curl_global_cleanup (); if (errorCount > 0) | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2015-07-14 22:30 | matwey | New Issue | |
2015-07-14 22:30 | matwey | File Added: libmicrohttpd_test_session.patch | |
2015-07-15 14:15 | Christian Grothoff | Note Added: 0009449 | |
2015-07-15 14:15 | Christian Grothoff | Status | new => resolved |
2015-07-15 14:15 | Christian Grothoff | Fixed in Version | => 0.9.43 |
2015-07-15 14:15 | Christian Grothoff | Resolution | open => fixed |
2015-07-15 14:15 | Christian Grothoff | Assigned To | => Christian Grothoff |
2015-07-15 14:15 | Christian Grothoff | Target Version | => 0.9.43 |
2015-09-16 11:00 | Christian Grothoff | Status | resolved => closed |
2021-09-02 17:54 | Christian Grothoff | Changeset attached | => libmicrohttpd master b118d605 |
2021-09-02 17:54 | Christian Grothoff | Note Added: 0018195 | |
2024-01-21 13:25 | Christian Grothoff | Category | HTTPS (SSL) => HTTPS (TLS) |