View Issue Details

IDProjectCategoryView StatusLast Update
0003716Talerexchangepublic2021-09-02 18:14
ReporterChristian Grothoff Assigned ToChristian Grothoff  
PriorityhighSeveritymajorReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.0Fixed in Version0.0 
Summary0003716: amount API does not deal well with overflow issues
DescriptionWe need a better API that reports overflows, setting to UINT_MAX may work with GNUnet-TIME API, but not for dealing with currencies.
TagsNo tags attached.

Relationships

related to 0003637 closedChristian Grothoff logic should deal better with arithmetic overflow/underflow issues 

Activities

Christian Grothoff

2015-03-18 19:03

manager   ~0009024

Fixed fully as of 6ba63aa..10f7551

Christian Grothoff

2021-09-02 18:14

manager   ~0018340

Fix committed to master branch.

Related Changesets

exchange: master 23bf1eee

2015-03-18 19:55

Christian Grothoff


Details Diff
fix 0003716: make sure amount-API offers proper checks against overflow and other issues Affected Issues
0003716
mod - src/include/taler_amount_lib.h Diff File
mod - src/include/taler_json_lib.h Diff File
mod - src/lib/mint_api.c Diff File
mod - src/mint/mint_db.c Diff File
mod - src/mint/mint_db.h Diff File
mod - src/mint/taler-mint-httpd_db.c Diff File
mod - src/mint/taler-mint-httpd_deposit.c Diff File
mod - src/mint/taler-mint-httpd_keystate.c Diff File
mod - src/mint/taler-mint-httpd_parsing.c Diff File
mod - src/mint/taler-mint-httpd_refresh.c Diff File
mod - src/mint/taler-mint-httpd_responses.c Diff File
mod - src/mint/taler-mint-keyup.c Diff File
mod - src/mint/taler-mint-reservemod.c Diff File
mod - src/util/amount.c Diff File
mod - src/util/json.c Diff File

exchange: master 6ba63aab

2015-03-18 19:56

Christian Grothoff


Details Diff
fix 0003716: make sure amount-API offers proper checks against overflow and other issues Affected Issues
0003716
mod - src/mint/mint_db.c Diff File

exchange: master 10f75510

2015-03-18 19:57

Christian Grothoff


Details Diff
fix 0003716: make sure amount-API offers proper checks against overflow and other issues Affected Issues
0003716
mod - src/mint/test_mint_db.c Diff File

Issue History

Date Modified Username Field Change
2015-03-17 11:08 Christian Grothoff New Issue
2015-03-18 18:34 Christian Grothoff Assigned To => Christian Grothoff
2015-03-18 18:34 Christian Grothoff Status new => assigned
2015-03-18 18:52 Christian Grothoff Relationship added related to 0003637
2015-03-18 19:03 Christian Grothoff Note Added: 0009024
2015-03-18 19:03 Christian Grothoff Status assigned => resolved
2015-03-18 19:03 Christian Grothoff Fixed in Version => 0.0
2015-03-18 19:03 Christian Grothoff Resolution open => fixed
2015-03-18 19:03 Christian Grothoff Target Version => 0.0
2015-03-22 17:17 Christian Grothoff Status resolved => closed
2016-02-18 15:43 Christian Grothoff Category mint => exchange
2021-09-02 18:14 Christian Grothoff Changeset attached => Taler-exchange master 10f75510
2021-09-02 18:14 Christian Grothoff Changeset attached => Taler-exchange master 6ba63aab
2021-09-02 18:14 Christian Grothoff Changeset attached => Taler-exchange master 23bf1eee
2021-09-02 18:14 Christian Grothoff Note Added: 0018340