View Issue Details

IDProjectCategoryView StatusLast Update
0003587GNUnetfile-sharing servicepublic2018-06-07 00:25
Reporteramatus Assigned To 
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionno change required 
Product VersionGit master 
Target Version0.11.0pre66Fixed in Version0.11.0pre66 
Summary0003587: gnunet-service-filesharing exausts memory
DescriptionA bug was introduced or triggered by revision 34633 that causes gnunet-service-filesharing to use up all available memory.
TagsNo tags attached.

Activities

Christian Grothoff

2014-12-20 13:07

manager   ~0008719

Wasn't introduced in that revision, that revision merely fixes the fact that the previous one failed to connect to other peers, a bug that was introduced in SVN 34563 earlier:

34563:
 {
- if (0 == memcmp (&my_id, peer, sizeof (struct GNUNET_PeerIdentity)))
+ if (0 != GNUNET_CRYPTO_cmp_peer_identity (&my_id,
+ peer))
     return;

34633:

- if (0 != GNUNET_CRYPTO_cmp_peer_identity (&my_id,
- peer))
+ if (0 ==
+ GNUNET_CRYPTO_cmp_peer_identity (&my_id,
+ peer))

So the leak was probably present before 34563 as well, just maked in between those two revisions by FS not properly talking to other peers at all.

amatus

2014-12-20 17:48

developer   ~0008720

I'll try the bisect again with the 34633 fix applied to each revision.

amatus

2014-12-21 00:34

developer   ~0008721

Watching the memory behavior more closely this doesn't look like a leak. The network has simply grown big enough that I need to restrict the number of peers I allow.

Issue History

Date Modified Username Field Change
2014-12-20 06:16 amatus New Issue
2014-12-20 13:07 Christian Grothoff Note Added: 0008719
2014-12-20 17:48 amatus Note Added: 0008720
2014-12-21 00:34 amatus Note Added: 0008721
2014-12-21 00:34 amatus Status new => resolved
2014-12-21 00:34 amatus Resolution open => no change required
2014-12-21 01:22 Christian Grothoff Fixed in Version => 0.11.0pre66
2014-12-21 01:22 Christian Grothoff Target Version => 0.11.0pre66
2018-06-07 00:25 Christian Grothoff Status resolved => closed