View Issue Details

IDProjectCategoryView StatusLast Update
0003428GNUnetset servicepublic2018-06-07 00:25
ReporterChristian GrothoffAssigned ToFlorian Dold 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN HEAD 
Target Version0.11.0pre66Fixed in Version0.11.0pre66 
Summary0003428: revocation test fails as set operation takes too long
Descriptiontest_revocation suddenly started to fail:

export GNUNET_FORCE_LOG="test-revocation;;;;DEBUG/revocation;;;;DEBUG/"
$ ./test_revocation
Parallelism: 4
Jun 04 18:54:33-728552 test-revocation-31232 DEBUG Starting HELPER process `/home/grothoff/lib//gnunet/libexec/gnunet-helper-testbed'
Jun 04 18:54:33-730045 test-revocation-31232 DEBUG Transmitted 3848 bytes to /home/grothoff/lib//gnunet/libexec/gnunet-helper-testbed
Jun 04 18:54:33-739981 test-revocation-31232 DEBUG Got 3861 bytes from helper `/home/grothoff/lib//gnunet/libexec/gnunet-helper-testbed'
Parallelism: 4
Jun 04 18:54:33-948302 test-revocation-31232 INFO Testbed connected peers
Jun 04 18:54:33-953343 test-revocation-31232 INFO Connected to CORE
Jun 04 18:54:33-953596 test-revocation-31232 INFO All peers connected ...
Jun 04 18:54:33-957115 test-revocation-31232 INFO Connected to identity
Jun 04 18:54:33-985580 test-revocation-31232 INFO Identities created
Jun 04 18:54:34-011163 test-revocation-31232 INFO Calculating proof of work...
Jun 04 18:54:34-022548 test-revocation-31232 INFO Done calculating proof of work
Jun 04 18:54:34-022627 test-revocation-31232 INFO Egos retrieved
Jun 04 18:54:34-023354 revocation-31255 DEBUG Received REVOKE message from client
Jun 04 18:54:34-074490 revocation-31255 DEBUG Added revocation info to SET
Jun 04 18:54:34-074801 test-revocation-31232 INFO Revocation successful
Jun 04 18:54:34-075243 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:34-950003 revocation-31253 DEBUG Peer `6ULB' connected to us
Jun 04 18:54:34-950090 revocation-31255 DEBUG Peer `6DER' connected to us
Jun 04 18:54:34-950158 revocation-31255 DEBUG Starting SET operation with peer `6DER'
Jun 04 18:54:35-075821 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:35-951307 revocation-31255 DEBUG Starting set exchange with peer `6DER'
Jun 04 18:54:36-076246 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:37-077670 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:38-079067 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:39-080482 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:40-081881 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:41-083271 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:42-084674 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:43-086093 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:44-087560 revocation-31253 DEBUG Received revocation check for valid key `44VP876R' from client
Jun 04 18:54:44-087716 test-revocation-31232 ERROR Flooding of revocation failed
Jun 04 18:54:44-092033 revocation-31253 DEBUG Peer `6ULB' disconnected from us
Jun 04 18:54:44-092042 revocation-31255 DEBUG Peer `6DER' disconnected from us
TagsNo tags attached.

Activities

Christian Grothoff

2014-06-04 19:02

manager   ~0008402

This is likely not a "performance" issue, I believe SET simply fails to perform the operation. Not sure why.

Florian Dold

2014-06-04 19:08

developer   ~0008403

Strange, for me the set test cases, the set profiler and consensus works, but test_revocation also fails.

Florian Dold

2014-06-04 19:24

developer   ~0008404

Is it possible that the revocation service does not call GNUNET_SET_commit appropriately for the set request that is accepted? I logged the calls to GNUNET_SET_commit, and only one of then occurs.

Florian Dold

2014-06-04 19:28

developer   ~0008405

Looks to me like a problem with revocation, not with set: gnunet-service-revocation.c calls GNUNET_SET_accept in l. 721, but never commits a set for the set operation.

Christian Grothoff

2014-06-04 19:48

manager   ~0008406

Indeed, adding a call to 'commit' on the accepting side fixed it. Odd that it worked before.

Issue History

Date Modified Username Field Change
2014-06-04 18:56 Christian Grothoff New Issue
2014-06-04 18:56 Christian Grothoff Status new => assigned
2014-06-04 18:56 Christian Grothoff Assigned To => Florian Dold
2014-06-04 19:02 Christian Grothoff Note Added: 0008402
2014-06-04 19:08 Florian Dold Note Added: 0008403
2014-06-04 19:24 Florian Dold Note Added: 0008404
2014-06-04 19:28 Florian Dold Note Added: 0008405
2014-06-04 19:28 Florian Dold Status assigned => feedback
2014-06-04 19:48 Christian Grothoff Note Added: 0008406
2014-06-04 19:48 Christian Grothoff Status feedback => assigned
2014-06-04 19:48 Christian Grothoff Status assigned => resolved
2014-06-04 19:48 Christian Grothoff Fixed in Version => 0.11.0pre66
2014-06-04 19:48 Christian Grothoff Resolution open => fixed
2018-06-07 00:25 Christian Grothoff Status resolved => closed