View Issue Details

IDProjectCategoryView StatusLast Update
0003281GNUnetbuild processpublic2014-04-08 16:41
Reporterandreas Assigned ToChristian Grothoff  
PriorityhighSeverityminorReproducibilityalways
Status closedResolutionopen 
Platformx86_64OSGNU/LinuxOS VersionGuix git
Product Version0.10.0 
Target Version0.10.1Fixed in Version0.10.1 
Summary0003281: Python 3 not supported
DescriptionWhen using python-3.3.3 from guix, "make check" fails with the following lines:

...
TEST: Viewing all stats...PASS
TEST: Viewing stats by name...Traceback (most recent call last):
  File "./test_gnunet_statistics.py", line 104, in <module>
    if len ([x for x in stdo.splitlines () if re.search ('43', x)]) != 1:
  File "./test_gnunet_statistics.py", line 104, in <listcomp>
    if len ([x for x in stdo.splitlines () if re.search ('43', x)]) != 1:
  File "/nix/store/b50aj7l8qhaxys65z57wcqhkyi22ni2i-python-3.3.3/lib/python3.3/re.py", line 161, in search
    return _compile(pattern, flags).search(string)
TypeError: can't use a string pattern on a bytes-like object
FAIL: test_gnunet_statistics.py

With python-2.7.6, I did not notice the problem. It looks as if the script is not python-3 compatible. It would be nice to fix it, or to check for the python version at configure time.
TagsNo tags attached.

Activities

Christian Grothoff

2014-02-11 13:34

manager   ~0008088

I've tried to reproduce this with Python 3 (and 3.3) but failed utterly on my system -- it just always 'works'. Anyway, reading up on the error message suggests the change I pushed in SVN 32307, which doesn't break anything on my system either. Please check if that helps on yours...

andreas

2014-03-02 17:55

reporter   ~0008125

Now that gnunet is in guix, things should be easier to test. Do you provide svn snapshot tarballs? I tried "make dist" on r32307 and the current revision, but it fails with
make[3]: *** No rule to make target `block_mesh.h', needed by `distdir'. Stop.

Christian Grothoff

2014-03-04 23:01

manager   ~0008131

Fixed the block_mesh.h issue in SVN 32503.

andreas

2014-03-06 22:24

reporter   ~0008134

Now "make dist" creates the tarball, but when I use it to build gnunet in the guix environment, the configure phase fails with:
   config.status: error: cannot find input file: `src/scalarproduct/Makefile.in'

Actually, src/scalarproduct is missing in the tarball.

Christian Grothoff

2014-03-07 07:32

manager   ~0008135

Somebody had commented it out in src/Makefile.am... Fixed in SVN HEAD.

andreas

2014-03-07 16:56

reporter   ~0008136

Now the gnunet build fails with
gnunet-ats-solver-eval.c:28:36: fatal error: gnunet-ats-solver-eval.h: No such file or directory
 #include "gnunet-ats-solver-eval.h"

A continuous build system executing a "make distcheck" after each commit would probably be useful.

Christian Grothoff

2014-03-07 20:54

manager   ~0008137

Well, 'distcheck' is known NOT to work as it fails to do 'make install' and won't set the prefix environment correctly and and and... So good idea, not quite as trivial to realize as I'd like.

Having a 'make dist' + 'make install/check' in the BBs might be an alternative, but they already take "forever" during their runs.

So far, I usually make the culprit responsible for one of those issues clean all of them up, but Matthias is on vacation... I've fixed the one you mentioned now, right now at least 'make install' does go through (on the dist'ed tgz).

andreas

2014-03-07 22:06

reporter   ~0008138

Very well, I confirm things do work with python 3 now also in my place. Thanks for looking into this!

Issue History

Date Modified Username Field Change
2014-01-25 15:04 andreas New Issue
2014-02-08 13:32 Christian Grothoff Priority normal => high
2014-02-11 13:34 Christian Grothoff Note Added: 0008088
2014-02-11 13:34 Christian Grothoff Assigned To => Christian Grothoff
2014-02-11 13:34 Christian Grothoff Status new => feedback
2014-03-02 17:55 andreas Note Added: 0008125
2014-03-02 17:55 andreas Status feedback => assigned
2014-03-04 23:01 Christian Grothoff Note Added: 0008131
2014-03-05 14:05 Christian Grothoff Status assigned => feedback
2014-03-06 22:24 andreas Note Added: 0008134
2014-03-06 22:24 andreas Status feedback => assigned
2014-03-07 07:32 Christian Grothoff Note Added: 0008135
2014-03-07 10:43 Christian Grothoff Status assigned => feedback
2014-03-07 16:56 andreas Note Added: 0008136
2014-03-07 16:56 andreas Status feedback => assigned
2014-03-07 20:54 Christian Grothoff Note Added: 0008137
2014-03-07 20:55 Christian Grothoff Status assigned => feedback
2014-03-07 22:06 andreas Note Added: 0008138
2014-03-07 22:06 andreas Status feedback => assigned
2014-03-07 22:09 Christian Grothoff Status assigned => resolved
2014-03-07 22:09 Christian Grothoff Fixed in Version => 0.10.1
2014-03-07 22:09 Christian Grothoff Target Version => 0.10.1
2014-04-08 16:41 Christian Grothoff Status resolved => closed