View Issue Details

IDProjectCategoryView StatusLast Update
0002676GNUnethello librarypublic2013-12-24 20:55
ReporterMatthias Wachs Assigned ToMatthias Wachs  
PriorityhighSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.10.0 
Summary0002676: Include a "Do not gossip flag" in HELLO messages
DescriptionWe should include a flag in the HELLO messages that indicates that the HELLO message SHOULd not be forwarded to other peers.

This helps to increase the efficency especially when running in F2F mode since peers not trusted by this peer can not connect.

TagsNo tags attached.

Activities

Matthias Wachs

2013-03-28 16:08

reporter   ~0007019

HELLO lib is extended to support new additional HELLO type
#define GNUNET_MESSAGE_TYPE_FRIEND_HELLO 17

Matthias Wachs

2013-03-28 16:44

reporter   ~0007020

transport support implemented in 26647.

tested by setting topology f2f to yes ... transport tests pass

Matthias Wachs

2013-04-03 16:28

reporter   ~0007032

2 possibilities:

a) Add a second messsage type
Already discussed ...

b) Extend struct HELLO_MASSAGE /w FRIEND_ONLY flag
Discussion: This breaks the protocol: we have a different struct HELLO_MASSAGE size but the same massage type -> protocol incompatibility

Matthias Wachs

2013-04-05 13:00

reporter   ~0007035

Requested feature implemented /w 26764:

Changed HELLO msg type from 16 to 17
Used reserved padding uint32_t to store friend flag

Modified peerinfo api and clients
Modified peerinfo service to return hellos based on friend flag

Possible issue:
Peer Identities without HELLO can still be leaked since there is not information about the friend only status when having no HELLO ...

Investigate about this

Matthias Wachs

2013-04-05 15:57

reporter   ~0007037

The challenge of implementation is done

More issues have to be discussed in 0002856

Issue History

Date Modified Username Field Change
2012-11-30 17:07 Matthias Wachs New Issue
2012-12-06 19:12 Christian Grothoff Status new => confirmed
2012-12-06 19:12 Christian Grothoff Target Version => 0.10.0
2012-12-21 20:32 Christian Grothoff Assigned To => Matthias Wachs
2012-12-21 20:32 Christian Grothoff Priority normal => high
2012-12-21 20:32 Christian Grothoff Status confirmed => assigned
2012-12-21 20:32 Christian Grothoff Product Version => Git master
2013-03-28 16:08 Matthias Wachs Note Added: 0007019
2013-03-28 16:44 Matthias Wachs Note Added: 0007020
2013-04-03 16:28 Matthias Wachs Note Added: 0007032
2013-04-03 16:28 Matthias Wachs Status assigned => feedback
2013-04-05 13:00 Matthias Wachs Note Added: 0007035
2013-04-05 13:00 Matthias Wachs Status feedback => assigned
2013-04-05 15:57 Matthias Wachs Note Added: 0007037
2013-04-05 15:57 Matthias Wachs Status assigned => resolved
2013-04-05 15:57 Matthias Wachs Resolution open => fixed
2013-12-24 20:55 Christian Grothoff Status resolved => closed