View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002567 | GNUnet | other | public | 2012-09-27 21:13 | 2013-12-24 20:54 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | ||
| Priority | low | Severity | text | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.10.0 | Fixed in Version | 0.10.0 | ||
| Summary | 0002567: relative time converted to string using "%llu ms" | ||||
| Description | Whenever we have a relative time, we should use GNUNET_STRINGS_relative_time_to_string (rt, YES/NO) to convert it to a human-readable string (with or without rounding, depending on the situation). However, this API is new and hence there are plenty of places in the code where this is not the case. You can get them using: $ bin/grepsrc.sh "%llu ms" Each of these should be replaced with "%s" and the respective format-string argument should be wrapped in the "GNUNET_STRINGS_relative_time_to_string" call. | ||||
| Additional Information | Current list: ./src/datastore/plugin_datastore_sqlite.c:496: "Storing in database block with type %u/key `%s'/priority %u/expiration in %llu ms (%lld).\n", ./src/datastore/perf_plugin_datastore.c:180: printf ("%s took %llu ms yielding %u/%u items\n", ./src/datastore/perf_plugin_datastore.c:222: printf ("%s took %llu ms yielding %u/%u items\n", ./src/datastore/perf_plugin_datastore.c:268: printf ("%s took %llu ms yielding %u/%u items\n", ./src/datastore/perf_plugin_datastore.c:361: printf ("%s took %llu ms for %llu items\n", "Storing an item", ./src/datastore/datastore_api.c:855: "Asked to put %u bytes of data under key `%s' for %llu ms\n", size, ./src/datastore/datastore_api.c:1271: LOG (GNUNET_ERROR_TYPE_DEBUG, "Asked to get replication entry in %llu ms\n", ./src/datastore/datastore_api.c:1333: "Asked to get %llu-th zero-anonymity entry of type %d in %llu ms\n", ./src/datastore/gnunet-service-datastore.c:345: "Deleting content `%s' of type %u that expired %llu ms ago\n", ./src/datastore/gnunet-service-datastore.c:407: "Deleting %llu bytes of low-priority (%u) content `%s' of type %u at %llu ms prior to expiration (still trying to free another %llu bytes)\n", ./src/core/test_core_quota_compliance.c:297: GNUNET_log (kind, "Peer 1 send rate: %llu b/s (%llu bytes in %llu ms)\n", ./src/core/test_core_quota_compliance.c:300: GNUNET_log (kind, "Peer 2 receive rate: %llu b/s (%llu bytes in %llu ms)\n", ./src/core/gnunet-service-core_neighbours.c:275: "Asking transport for transmission of %u bytes to `%4s' in next %llu ms\n", ./src/util/bandwidth.c:117: "Bandwidth suggests delay of %llu ms for %llu bytes of traffic\n", ./src/util/bandwidth.c:186: "Tracker %p updated, have %u Bps, last update was %llu ms ago\n", av, ./src/util/bandwidth.c:269: LOG (GNUNET_ERROR_TYPE_DEBUG, "Tracker %p delay for %u bytes is %llu ms\n", ./src/util/network.c:1523: LOG (GNUNET_ERROR_TYPE_DEBUG, "nfds: %d, handles: %d, will wait: %llu ms\n", ./src/util/test_scheduler_delay.c:79: FPRINTF (stdout, "Sleep precision: %llu ms. ", ./src/util/perf_crypto_hash.c:60: printf ("Hash perf took %llu ms\n", ./src/util/test_speedup.c:107: GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Execution time in GNUnet time: %llu ms\n", ./src/util/test_speedup.c:109: GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Execution time in system time: %llu ms\n", ./src/util/test_speedup.c:113: GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Execution time in GNUnet time: %llu ms\n", ./src/util/test_speedup.c:115: GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Execution time in system time: %llu ms\n", ./src/util/resolver_api.c:706: "Will try to connect to DNS service in %llu ms\n", ./src/util/speedup.c:51: "Speeding up execution time by %llu ms\n", delta.rel_value); ./src/util/speedup.c:71: "Speed up execution time %llu ms every %llu ms\n", ./src/util/test_crypto_rsa.c:119: printf ("%d RSA encrypt operations %llu ms (%d failures)\n", ITER, ./src/util/test_crypto_rsa.c:256: printf ("%d RSA sign operations %llu ms\n", ITER, ./src/nse/nse_api.c:153: "Scheduling task to reconnect to nse service in %llu ms.\n", ./src/nse/gnunet-service-nse.c:524: "Transmitting previous round behind schedule in %llu ms\n", ./src/nse/gnunet-service-nse.c:535: "For round %llu, delay for %u matching bits is %llu ms\n", ./src/dht/dht_api.c:441: "Disconnecting from DHT service, will try to reconnect in %llu ms\n", ./src/arm/test_exponential_backoff.c:336: FPRINTF (killLogFilePtr, "Waited for: %llu ms\n", ./src/arm/gnunet-service-arm.c:1021: ("Service `%s' terminated with status %s/%d, will restart in %llu ms\n"), ./src/ats/gnunet-service-ats_reservations.c:69: "Delay to satisfy reservation for %d bytes is %llu ms\n", ./src/ats/test_ats_api_bandwidth_consumption.c:137: "ATS reserved bandwidth of %i to peer `%s' in %llu ms\n", amount, ./src/ats/test_ats_api_bandwidth_consumption.c:149: "Trying to reserver bandwidth of %i to peer `%s' in %llu ms\n", ./src/ats/gnunet-service-ats_addresses.c:665: "Address %p blocked for suggestion for %llu ms \n", ./src/ats/perf_ats_mlp.c:294: GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Problem solved for %u peers with %u address successfully (LP: %llu ms / MLP: %llu ms)\n", ./src/ats/perf_ats_mlp.c:318: GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Updated problem solved for %u peers with %u address successfully (Initial: LP/MLP: %llu/%llu ms, Update: %llu/%llu ms)\n", ./src/fs/gnunet-service-fs_pr.c:1574: "Asking to stop migration for %llu ms because of load %f and events %d/%d\n", ./src/fs/gnunet-service-fs_pe.c:317: "Considering (re)transmission number %u in %llu ms\n", ./src/fs/gnunet-service-fs_pe.c:467: "Sleeping for %llu ms before retrying requests on plan %p.\n", ./src/fs/gnunet-service-fs_cp.c:1712: GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Asking to stop migration for %llu ms\n", ./src/transport/gnunet-service-transport_neighbours.c:1352: "Latency for peer `%s' is %llu ms\n", ./src/transport/gnunet-service-transport_neighbours.c:1444: "Throttling read (%llu bytes excess at %u b/s), waiting %llu ms before reading more.\n", ./src/transport/gnunet-service-transport_neighbours.c:2352: "Master task runs for neighbour `%s' in state %s with timeout in %llu ms\n", ./src/transport/plugin_transport_http_server_old.c:294: "Server: peer `%s' address `%s' next read delayed for %llu ms\n", ./src/transport/plugin_transport_http_server_old.c:801: "Server: %p no inbound bandwidth available! Next read was delayed by %llu ms\n", ./src/transport/plugin_transport_http_server_old.c:1102: "Scheduling IPv4 server task in %llu ms\n", tv); ./src/transport/plugin_transport_http_server_old.c:1118: "Scheduling IPv6 server task in %llu ms\n", tv); ./src/transport/plugin_transport_http_server.c:1265: "Peer `%s' address `%s' next read delayed for %llu ms\n", ./src/transport/plugin_transport_http_server.c:1427: "Session %p / Connection %p: no inbound bandwidth available! Next read was delayed by %llu ms\n", ./src/transport/plugin_transport_http_server.c:1711: "Scheduling IPv4 server task in %llu ms\n", tv); ./src/transport/plugin_transport_http_server.c:1727: "Scheduling IPv6 server task in %llu ms\n", tv); ./src/transport/plugin_transport_http_server.c:2756: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_http_server.c:2778: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_http_server.c:2799: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_udp.c:851: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_udp.c:870: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_udp.c:889: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_http_client.c:878: "Client: peer `%s' address `%s' next read delayed for %llu ms\n", ./src/transport/plugin_transport_http_client.c:933: "Session %p / connection %p: No inbound bandwidth available! Next read was delayed for %llu ms\n", ./src/transport/plugin_transport_http_client.c:1437: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_http_client.c:1460: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_http_client.c:1482: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_tcp.c:2050: "Throttling receiving from `%s' for %llu ms\n", ./src/transport/plugin_transport_tcp.c:2192: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_tcp.c:2211: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_tcp.c:2230: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_http.c:1266: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_http.c:1289: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_http.c:1308: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_unix.c:1246: "Session %p was idle for %llu ms, disconnecting\n", ./src/transport/plugin_transport_unix.c:1265: "Timeout for session %p set to %llu ms\n", ./src/transport/plugin_transport_unix.c:1284: "Timeout rescheduled for session %p set to %llu ms\n", ./src/transport/plugin_transport_http_client_old.c:358: "Client: peer `%s' address `%s' next read delayed for %llu ms\n", ./src/transport/plugin_transport_http_client_old.c:414: "Client: %p No inbound bandwidth available! Next read was delayed for %llu ms\n", ./src/transport/transport_api.c:792: "Scheduling next transmission to service in %llu ms\n", ./src/transport/transport_api.c:929: "Scheduling task to reconnect to transport service in %llu ms.\n", ./src/transport/transport_api.c:1303: "Bandwidth tracker allows next transmission to peer %s in %llu ms\n", ./src/transport/gnunet-service-transport.c:306: "Allowing receive from peer %s to continue in %llu ms\n", ./src/mesh/test_mesh_small.c:397: FPRINTF (stderr, "\nTest time %llu ms\n", ./src/mesh/test_mesh_local_traffic.c:512: FPRINTF (stderr, "\nTest time %llu ms\n", | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-09-27 21:13 | Christian Grothoff | New Issue | |
| 2012-09-27 21:46 | Christian Grothoff | Priority | normal => low |
| 2012-10-07 12:54 | Christian Grothoff | Status | new => confirmed |
| 2013-08-11 23:26 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2013-08-11 23:26 | Christian Grothoff | Status | confirmed => assigned |
| 2013-08-11 23:26 | Christian Grothoff | Note Added: 0007338 | |
| 2013-08-11 23:26 | Christian Grothoff | Status | assigned => resolved |
| 2013-08-11 23:26 | Christian Grothoff | Fixed in Version | => 0.10.0 |
| 2013-08-11 23:26 | Christian Grothoff | Resolution | open => fixed |
| 2013-08-11 23:27 | Christian Grothoff | Target Version | => 0.10.0 |
| 2013-12-24 20:54 | Christian Grothoff | Status | resolved => closed |
