View Issue Details

IDProjectCategoryView StatusLast Update
0002445GNUnetobsoletepublic2024-05-03 13:49
ReporterMatthias Wachs Assigned ToMatthias Wachs  
PriorityurgentSeveritycrashReproducibilitysometimes
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.9.4 
Summary0002445: ATS uses terminated session
DescriptionSession is terminated by plugin->env->session_end

But ATS does not delete it
Steps To ReproduceRun a peer and wait for a segfault with valgrind

This happens rareley:

I had 30 connections to other peers, the session is terminated at a certain point and reused after a long time
TagsNo tags attached.

Activities

Matthias Wachs

2012-06-26 10:10

reporter   ~0006148

Session is not destroyed when session is terminated in state "S_DISCONNECT_FINISHED"

Matthias Wachs

2012-06-26 10:45

reporter   ~0006149

in transport_neighbours:free_address

GNUNET_ATS_address_destroyed is not called since branch is not taken:
  if (GNUNET_YES == na->ats_active)
  {
    ...
    GNUNET_ATS_address_destroyed (GST_ats, na->address, na->session);
  }

Matthias Wachs

2012-06-29 15:53

reporter   ~0006178

Plan how it should work in the end:

- plugin calls env_session_end
- gnunet-service-transport_neighbours sets session to unused
- gnunet-service-transport tells ats that session is destroyed

Matthias Wachs

2012-06-29 17:06

reporter   ~0006180

Last edited: 2012-06-29 17:40

Current issue:

in free_neighbour

- We first tell the plugins to disconnect:
    papi->disconnect (papi->cls, &n->id);
- We then receive a session_terminated
- We then call free_address which tries to set address unused

So we get an error message: "Trying to set unknown address to unused for peer"
At least when we explicitly from an peer

Matthias Wachs

2012-07-02 09:53

reporter   ~0006187

fixed with rev 22422.

Issue History

Date Modified Username Field Change
2012-06-20 18:14 Matthias Wachs New Issue
2012-06-20 18:14 Matthias Wachs Status new => assigned
2012-06-20 18:14 Matthias Wachs Assigned To => Matthias Wachs
2012-06-22 11:01 Christian Grothoff Target Version => 0.9.4
2012-06-26 10:10 Matthias Wachs Note Added: 0006148
2012-06-26 10:45 Matthias Wachs Note Added: 0006149
2012-06-29 15:53 Matthias Wachs Note Added: 0006178
2012-06-29 17:06 Matthias Wachs Note Added: 0006180
2012-06-29 17:15 Matthias Wachs Note Edited: 0006180
2012-06-29 17:40 Matthias Wachs Note Edited: 0006180
2012-07-02 09:53 Matthias Wachs Note Added: 0006187
2012-07-02 09:53 Matthias Wachs Status assigned => resolved
2012-07-02 09:53 Matthias Wachs Resolution open => fixed
2012-11-05 18:34 Christian Grothoff Status resolved => closed
2024-05-03 13:49 Christian Grothoff Category ATS service => obsolete