View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002260 | GNUnet | DHT service | public | 2012-04-10 14:22 | 2012-06-02 19:15 |
| Reporter | schanzen | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0002260: Disconnect in DHT put continuation is dangerous | ||||
| Description | The continuation of a put call in the DHT cannot be used to disconnect from the DHT service because the handle is still needed after the continuation. Workarounds: use a SCHEDULER_add_now in continuation and disconnect from service after the api call. However this should work transparently because the user of the api cannot know how long the handle is still needed | ||||
| Steps To Reproduce | 1. Connect to DHT 2. Put sth and add continuation 3. Disconnect from DHT service in continuation | ||||
| Tags | No tags attached. | ||||
| related to | 0002277 | closed | Christian Grothoff | DHT PUT continuation should only be called after confirmation from service |
|
|
Added documentation in src |
|
|
The note will help as to avoid the bug. But when exactly is the disconnect supposed to be called. I.e. How can you determine when all puts have finished? |
|
|
(11:33:58 AM) schanzen: how/when is the disconnect supposed to happen? (11:35:02 AM) grothoff-office: You just add another task (GNUNET_SCHEDULER_add_now) inside the 'cont' and in that task do the disconnect. |
|
|
Issue is documented, I double checked that it is not possible to re-write the code to always call 'cont' from a location where it would be safe to call GNUNET_DHT_disconnect directly. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-10 14:22 | schanzen | New Issue | |
| 2012-04-12 10:46 | Matthias Wachs | Note Added: 0005710 | |
| 2012-04-12 10:46 | Matthias Wachs | Note Edited: 0005710 | |
| 2012-04-12 10:57 | schanzen | Note Added: 0005711 | |
| 2012-04-12 11:35 | Christian Grothoff | Note Added: 0005712 | |
| 2012-04-23 17:58 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2012-04-23 17:58 | Christian Grothoff | Status | new => assigned |
| 2012-04-23 17:59 | Christian Grothoff | Relationship added | duplicate of 0002277 |
| 2012-04-23 17:59 | Christian Grothoff | Relationship deleted | 0002277 |
| 2012-04-23 17:59 | Christian Grothoff | Relationship added | related to 0002277 |
| 2012-04-23 18:02 | Christian Grothoff | Target Version | => 0.9.3 |
| 2012-04-26 18:55 | Christian Grothoff | Note Added: 0005749 | |
| 2012-04-26 18:55 | Christian Grothoff | Status | assigned => resolved |
| 2012-04-26 18:55 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2012-04-26 18:55 | Christian Grothoff | Resolution | open => fixed |
| 2012-06-02 19:15 | Christian Grothoff | Status | resolved => closed |