View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001939 | GNUnet | WLAN transport | public | 2011-11-22 20:04 | 2012-06-02 19:15 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | ||
| Priority | high | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0001939: code cleanup required | ||||
| Description | The WLAN plugin needs a code review; the sub-directory wlan/ should be removed, headers inlined and especially the SUID processes deserve a good review. | ||||
| Tags | No tags attached. | ||||
| parent of | 0001982 | closed | David Brodski | implicit declaration of function 'htole16' |
|
|
Open issues: 1) 'struct ieee80211_frame' is defined *differently* in different c files 2) not everything in 'gnunet-transport-wlan-helper.c' is documented, 3) IPC Message structs are not nicely defined (lots of headers+ptr-arithmetic, 'struct Radiotap_rx' and 'struct Radiotap_Send' should likely be embedded in some larger structs). Protocol between helper and plugin should be documented! 4) some fields in 'struct Radiotap_rx' are never set; virtually all are never used (!) 5) 'struct ieee80211_radiotap_header' and 'struct ieee80211_frame' are confusing (names are not great, can we simplify?); naming conventions are not followed here either. 6) unnamed constants (i.e. '31' -- is that the same as 'RADIOTAP_EXT' or is it a different 31)? 7) use of 'int' vs. 'unsigned int' types does not seem to be consistent 8) Overall, gnunet-transport-wlan-helper.c is not ready for audit yet |
|
|
(1) is fixed in SVN 20495. Also, (3) is now fixed in one direction. |
|
|
(3) is fixed in SVN 20574. |
|
|
As of 20581, I consider the WLAN helper to be clean code. More testing might be good, though... |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-22 20:04 | Christian Grothoff | New Issue | |
| 2011-11-22 20:04 | Christian Grothoff | Status | new => assigned |
| 2011-11-22 20:04 | Christian Grothoff | Assigned To | => David Brodski |
| 2011-11-22 20:17 | Christian Grothoff | Assigned To | David Brodski => |
| 2011-11-22 20:17 | Christian Grothoff | Status | assigned => confirmed |
| 2011-11-22 20:45 | Christian Grothoff | Severity | feature => tweak |
| 2011-12-01 10:05 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2011-12-01 10:05 | Christian Grothoff | Target Version | => 0.9.1 |
| 2011-12-08 16:52 | Christian Grothoff | Relationship added | parent of 0001982 |
| 2011-12-11 16:31 | Christian Grothoff | Note Added: 0005040 | |
| 2011-12-19 22:45 | Christian Grothoff | Target Version | 0.9.1 => 0.9.2 |
| 2012-01-22 21:21 | Christian Grothoff | Target Version | 0.9.2 => 0.9.3 |
| 2012-02-28 18:42 | Christian Grothoff | Status | confirmed => assigned |
| 2012-03-05 01:48 | Christian Grothoff | Priority | normal => high |
| 2012-03-14 16:03 | Christian Grothoff | Note Added: 0005609 | |
| 2012-03-16 16:34 | Christian Grothoff | Note Added: 0005620 | |
| 2012-03-16 21:53 | Christian Grothoff | Note Added: 0005621 | |
| 2012-03-16 21:53 | Christian Grothoff | Status | assigned => resolved |
| 2012-03-16 21:53 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2012-03-16 21:53 | Christian Grothoff | Resolution | open => fixed |
| 2012-06-02 19:15 | Christian Grothoff | Status | resolved => closed |
