View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001770 | GNUnet | DHT service | public | 2011-09-16 10:25 | 2011-09-18 14:59 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | ||
| Priority | urgent | Severity | major | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Summary | 0001770: DHT includes unique id (uid) in each message, likely for no good reason | ||||
| Description | The UID is then checked for replies. But why would we need to do that? A valid reply is a valid reply. A duplicate reply is a duplicate reply. It should not matter if we got the good reply in response to our own query or not. I suspect this was added for profiling/debugging, but if so it should probably not stay for production use and be removed VERY soon. | ||||
| Additional Information | Addressing this (possibly simply by removing the code) is urgent as it would change the network protocol. | ||||
| Tags | No tags attached. | ||||
| related to | 0001776 | closed | Christian Grothoff | dht multipeer test fails SOMETIMES |
|
|
The unique identifier is primarily used for testing/profiling purposes, specifically logging the path of DHT requests as they travel through our test topologies. So it should probably NOT be in any production release so that it will be compatible with future versions. However, it is VERY useful for profiling/debugging so perhaps #ifdef'ing it out would be the best option in case anyone uses the sql profiling stuff in the future... |
|
|
Ok, let's #ifdef then for now. |
|
|
Yuck. You use 'struct GNUNET_DHT_RouteMessage' for both P2P and CS communication. For CS, you need the UID for cancellation, so there it cannot be removed. Yuck. |
|
|
Actually, it is not shared, your comment is just wrong. |
|
|
Added an option 'HAVE_UID_FOR_TESTING' which is (by default, now) set to GNUNET_NO to disable the UID in P2P messages (we still need it for CS-messages so that requests can be aborted). |
|
|
Fixed in SVN 16907. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-09-16 10:25 | Christian Grothoff | New Issue | |
| 2011-09-16 10:25 | Christian Grothoff | Status | new => assigned |
| 2011-09-16 10:25 | Christian Grothoff | Assigned To | => mrwiggles |
| 2011-09-16 18:17 | mrwiggles | Note Added: 0004585 | |
| 2011-09-16 19:26 | Christian Grothoff | Note Added: 0004586 | |
| 2011-09-16 19:29 | Christian Grothoff | Note Added: 0004587 | |
| 2011-09-16 19:31 | Christian Grothoff | Note Added: 0004588 | |
| 2011-09-16 19:51 | Christian Grothoff | Assigned To | mrwiggles => Christian Grothoff |
| 2011-09-16 20:25 | Christian Grothoff | Note Added: 0004589 | |
| 2011-09-16 20:26 | Christian Grothoff | Note Added: 0004590 | |
| 2011-09-16 20:26 | Christian Grothoff | Status | assigned => resolved |
| 2011-09-16 20:26 | Christian Grothoff | Resolution | open => fixed |
| 2011-09-16 20:51 | Christian Grothoff | Relationship added | related to 0001776 |
| 2011-09-18 14:59 | Christian Grothoff | Status | resolved => closed |
