View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001673 | GNUnet | other | public | 2011-04-04 13:14 | 2011-09-19 10:45 |
| Reporter | toelke | Assigned To | vminko | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001673: Build fails in gnunet-chat.c: Value is not member of enum GNUNET_CHAT_MsgOptions | ||||
| Description | When building HEAD, I get the following message: cc1: warnings being treated as errors gnunet-chat.c: In function | ||||
| Tags | No tags attached. | ||||
| Attached Files | gnunet-bug1673-fix.patch (6,224 bytes)
Index: src/chat/test_chat.c
===================================================================
--- src/chat/test_chat.c (revision 14858)
+++ src/chat/test_chat.c (working copy)
@@ -64,7 +64,7 @@
const char *me;
- enum GNUNET_CHAT_MsgOptions opt;
+ uint32_t opt;
uint32_t sequence_number;
@@ -200,7 +200,7 @@
member_list_cb (void *cls,
const struct GNUNET_CONTAINER_MetaData *member_info,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *member_id,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
struct Wanted *want = cls;
GNUNET_HashCode sender;
@@ -246,7 +246,7 @@
const struct GNUNET_CONTAINER_MetaData *meta,
const char *message,
struct GNUNET_TIME_Absolute timestamp,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
struct Wanted *want = cls;
@@ -409,7 +409,7 @@
send_to_bob (void *cls,
const struct GNUNET_SCHEDULER_TaskContext *tc)
{
- enum GNUNET_CHAT_MsgOptions options;
+ uint32_t options;
uint32_t *seq = NULL;
#if VERBOSE
Index: src/chat/chat.c
===================================================================
--- src/chat/chat.c (revision 14858)
+++ src/chat/chat.c (working copy)
@@ -114,7 +114,7 @@
/**
* Options for the message.
*/
- enum GNUNET_CHAT_MsgOptions options;
+ uint32_t options;
/**
* Receiver of the message. NULL to send to everyone in the room.
@@ -665,7 +665,7 @@
const char *nick_name,
struct GNUNET_CONTAINER_MetaData *member_info,
const char *room_name,
- enum GNUNET_CHAT_MsgOptions msg_options,
+ uint32_t msg_options,
GNUNET_CHAT_JoinCallback joinCallback,
void *join_cls,
GNUNET_CHAT_MessageCallback messageCallback,
@@ -824,7 +824,7 @@
void
GNUNET_CHAT_send_message (struct GNUNET_CHAT_Room *room,
const char *message,
- enum GNUNET_CHAT_MsgOptions options,
+ uint32_t options,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *receiver,
uint32_t *sequence_number)
{
Index: src/chat/test_chat_private.c
===================================================================
--- src/chat/test_chat_private.c (revision 14858)
+++ src/chat/test_chat_private.c (working copy)
@@ -70,7 +70,7 @@
const char *me;
- enum GNUNET_CHAT_MsgOptions opt;
+ uint32_t opt;
struct GNUNET_TIME_Absolute timestamp;
@@ -219,7 +219,7 @@
member_list_cb (void *cls,
const struct GNUNET_CONTAINER_MetaData *member_info,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *member_id,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
struct Wanted *want = cls;
GNUNET_HashCode sender;
@@ -287,7 +287,7 @@
const struct GNUNET_CONTAINER_MetaData *meta,
const char *message,
struct GNUNET_TIME_Absolute timestamp,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
struct Wanted *want = cls;
Index: src/chat/gnunet-chat.c
===================================================================
--- src/chat/gnunet-chat.c (revision 14858)
+++ src/chat/gnunet-chat.c (working copy)
@@ -111,7 +111,7 @@
const struct GNUNET_CONTAINER_MetaData *member_info,
const char *message,
struct GNUNET_TIME_Absolute timestamp,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
char *nick;
char *time;
@@ -207,7 +207,7 @@
member_list_cb (void *cls,
const struct GNUNET_CONTAINER_MetaData *member_info,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *member_id,
- enum GNUNET_CHAT_MsgOptions options)
+ uint32_t options)
{
char *nick;
GNUNET_HashCode id;
Index: src/include/gnunet_chat_service.h
===================================================================
--- src/include/gnunet_chat_service.h (revision 14858)
+++ src/include/gnunet_chat_service.h (working copy)
@@ -115,7 +115,7 @@
const struct GNUNET_CONTAINER_MetaData *member_info,
const char *message,
struct GNUNET_TIME_Absolute timestamp,
- enum GNUNET_CHAT_MsgOptions options);
+ uint32_t options);
/**
* Callback used for notification that another room member has joined or left.
@@ -130,7 +130,7 @@
typedef int (*GNUNET_CHAT_MemberListCallback) (void *cls,
const struct GNUNET_CONTAINER_MetaData *member_info,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *member_id,
- enum GNUNET_CHAT_MsgOptions options);
+ uint32_t options);
/**
* Callback used for message delivery confirmations.
@@ -178,7 +178,7 @@
const char *nick_name,
struct GNUNET_CONTAINER_MetaData *member_info,
const char *room_name,
- enum GNUNET_CHAT_MsgOptions msg_options,
+ uint32_t msg_options,
GNUNET_CHAT_JoinCallback joinCallback,
void *join_cls,
GNUNET_CHAT_MessageCallback messageCallback,
@@ -201,7 +201,7 @@
void
GNUNET_CHAT_send_message (struct GNUNET_CHAT_Room *room,
const char *message,
- enum GNUNET_CHAT_MsgOptions options,
+ uint32_t options,
const struct GNUNET_CRYPTO_RsaPublicKeyBinaryEncoded *receiver,
uint32_t *sequence_number);
| ||||
|
|
Assign to me. I'll take a look at this issue today. |
|
|
Proposed fix is attached. |
|
|
I'm not sure I like removing that enum like that. |
|
|
Resolved in new HEAD (r14883) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-04-04 13:14 | toelke | New Issue | |
| 2011-04-04 14:28 | vminko | Note Added: 0004300 | |
| 2011-04-04 23:17 | vminko | File Added: gnunet-bug1673-fix.patch | |
| 2011-04-04 23:18 | vminko | Note Added: 0004301 | |
| 2011-04-06 09:07 | Christian Grothoff | Status | new => assigned |
| 2011-04-06 09:07 | Christian Grothoff | Assigned To | => vminko |
| 2011-04-06 09:11 | Christian Grothoff | Note Added: 0004302 | |
| 2011-04-06 09:17 | toelke | Note Added: 0004303 | |
| 2011-04-06 09:18 | toelke | Status | assigned => resolved |
| 2011-04-06 09:18 | toelke | Fixed in Version | => Git master |
| 2011-04-06 09:18 | toelke | Resolution | open => fixed |
| 2011-04-27 16:18 | Christian Grothoff | Status | resolved => closed |
| 2011-09-19 10:45 | Christian Grothoff | Fixed in Version | Git master => 0.9.0pre3 |
| 2011-09-19 10:45 | Christian Grothoff | Target Version | => 0.9.0pre3 |
